I spend quite a while creating the attached gmap filter.
However when I add it to article and try to preview or save it, its lost.
If I half the length it appears to work fine. Is there a maxmim gmap filter size?
Or is there perhaps a general filter maximum size?
Can this be fix, so that I am able to use the attach large gmap filter?

CommentFileSizeAuthor
gmap.cycle67.02 KBNick Brown

Comments

webgeer’s picture

webgeer commented
Category: bug » support
Priority: Critical » Normal

There is no maximum size built into the gmap filter, so I suspect that this is a limitation of the filter system.

Unfortunately I don't know of an easy way of fixing this. Sorry.

Nick Brown’s picture

Nick Brown commented
Title: maximum gmap filter size? » maximum filter size?
Project: GMap Module » Drupal core
Version: 6.x-1.x-dev » x.y.z
Component: Code » filter.module
Category: support » bug

Forwarding to Drupal core.
Is there a maximum filter size that is preventing this gmap filter working?

Nick Brown’s picture

Nick Brown commented

When attempting to save or preview content with the filter in it, it silently drops the filter (and does not even save it) with no warning or error message given. (or in the logs).
If there is a maximum limit then it needs to documented, and a warning given. simply losing the filter is not very friendly.

Nick Brown’s picture

Nick Brown commented
Version: x.y.z » 4.7.4

Is there any logging or debugs I can enable to help figure out what is happening here?
Or can someone point me at code I should perhaps start looking at?

Nick Brown’s picture

Nick Brown commented
Title: maximum filter size? » large filters dropped without warning
Version: 4.7.4 » 4.7.x-dev
Nick Brown’s picture

Nick Brown commented
Version: 4.7.x-dev » 5.x-dev
Priority: Normal » Critical

Just updated to 5.1 and its still happens.
There is no warning or logging, it simply drops the filter.

stevenpatz’s picture

stevenpatz
he/him
commented
Priority: Critical » Normal
Status: Active » Postponed (maintainer needs more info)
Nick Brown’s picture

Nick Brown commented

What extra info is needed?
Drupal reports nothing and silently drops the filter.
I've already attached a gmap filter that can be used to reproduce the problem.

Nick Brown’s picture

Nick Brown commented
Status: Postponed (maintainer needs more info) » Active
Nick Brown’s picture

Nick Brown commented
Priority: Normal » Critical

Increasing to critical as the no warning etc is logged when the filter is dropped.

Nick Brown’s picture

Nick Brown commented

Has anyone been able to reproduce this with the gmap filter attached to the report?

marcingy’s picture

marcingy commented

I have just tried this on my localhost and the filter is correctly converted into the javascript required to build the map. Maybe you should try updating to the new version of gmap module as this what I'm using.

marcingy’s picture

marcingy commented
Status: Active » Fixed
Nick Brown’s picture

Nick Brown commented
Priority: Critical » Normal
Status: Fixed » Active

I've update gmap module to the latest version and still it does not work.
Perhaps its a php config issue? Are there any debugs I can turn on to determine what is happening, as currently drupal does not log or warn about anything and simply drops the filter.

marcingy’s picture

marcingy commented

I'm not sure!! My test environment where I tried it is windows/apache based and uses the standard php.ini file that is installed by Xampp apart from a small change to allow me to use eclipse for debugging. I use the standard drupal config file and my version of PHP is 4.

Nick Brown’s picture

Nick Brown commented
Priority: Normal » Critical

Link to another bug report relating to a filter that silently does not produce any content for inserting into the node.
http://drupal.org/node/151767

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Active » Closed (won't fix)

This is probably due to the teaser size configuration on the Post Settings administration page. Try raising that or adding an explicit break as explained in the node preview.

Nick Brown’s picture

Nick Brown commented
Status: Closed (won't fix) » Active

Nothing to with teaser size configuration, as its effects even the full node. I've tried setting an explicit break, and still the filter places nothing into the full node and teaser.

drumm’s picture

drumm
he/him
Location NY, US
commented
Project: Drupal core » GMap Module
Version: 5.x-dev » 5.x-1.x-dev
Component: filter.module » Code

This is probably a problem with the gmap module. I can not think of any restrictions in core which might cause this issue.

bdragon’s picture

bdragon commented

Oh, wow, that's an impressive macro!

Do you mind if I use it as a testcase after we figure out what's going on here?

Nick Brown’s picture

Nick Brown commented

Feel free to use it as a test case. If I can do anything to help with tracking this problem down then let me know.

Nick Brown’s picture

Nick Brown commented

Has anyone been able to reproduce this yet?
It happens everytime for me, and with nothing logged by drupal, its impossible to figure out what the cause is. :-(

bdragon’s picture

bdragon commented

Hmm, I am seeing the markers but not the lines...

steinmb’s picture

steinmb commented

Latest version of Gmap
I see the markers, but no lines. Reducing the size of the macro does not correct the problem. Are you sure it is a problem with size and not lines that are currently broken?

--
Stein M. Bjorklund

bdragon’s picture

bdragon commented

Actually, lines ARE broken, and I'm working on repairing them...

bdragon’s picture

bdragon commented

Lines are repaired.

But...

This test case is a MONSTER... GPolyline seems to degenerate quickly when the lines have large numbers of points. I wasn't able to get the whole thing to display on my machine, I gave up after about 10 minutes of hitting the "continue script..." button...

I hear that GML / KML works better for large polys...

Perhaps adding a system to store / retrieve KML would help.... Possibly caching the data and passing a key automatically if there are lines over a certain length? (md5 of the points array?)

Nick Brown’s picture

Nick Brown commented

It does not even get that far for me. The filter appears to generate nothing. The page contains no javascript and no map is displayed at all. :-(

bdragon’s picture

bdragon commented

Could you try
A) Resaving the node
B) Checking the input format
C) Posting the list of filters active for that format
and
D) Posting your list of activated modules?

Smaller filters work for you, right? What browser are you using?

steinmb’s picture

steinmb commented

I have tested the latest version a little more.
- Firefox, Looks like it show all the lines and marks just fine. Uses 4-5sek to render.
- Safari 3.0.3, partly broken. Give a warning after 4-5 sek, about slow script. Show all markers, some part of the lines is showing. Very very buggy.
- Opera 9.23 is 100% broken. No markers and no lines. Normally marks work just fine in Opera.

--
Stein M. Bjorklund

Nick Brown’s picture

Nick Brown commented

I'm using gmap.module,v 1.51.2.93 2007/08/28 20:38:16

I'm inserting the filter into blog entry node using the Filtered HTML input format;

Filtered HTML
* Allowed HTML tags:


      • Only local images are allowed.

        * Lines and paragraphs break automatically.
        * Images can be added to this post.
        * Insert Google Map macro.Create a macro

        It has the following filters;

        HTML filter 0
        Line break converter 1
        Inline images 9
        GMap filter 10

        I have the following modules enabled;

        blog
        comment
        forum
        help
        legacy
        menu
        path
        profile
        search
        statistics
        taxonomy
        throttle
        block
        filter
        node
        system
        user
        watchdog
        image
        image attach
        image gallery
        image assist
        gmap
        gmap location
        gmap macro builder
        location

        I don't think it has anything to do the browser viewing the page, (and I've tried firefox/epiphany/IE) as the filter does appear to insert anything into the node in the first page. (I copy the filter into the edit box and then save or preview the page and nothing is their, even when looking at the page source. The filter is saved into the node though for future editing.)

        If I insert a smaller filter, say half of the larger filter I attached, it works fine, and the filter inserts a map into the node.

    • bdragon’s picture

    bdragon commented

    Does it work if you put gmap in an input format all by itself? Maybe something's attempting to insert line breaks in the middle of the macro...

    bdragon’s picture

    bdragon commented
    Status: Active » Closed (fixed)

    Closing, I'm assuming this works now and it was a filter ordering issue. Please reopen if you can still reproduce on RC2.