sort information isn't maintained across form submission

I think I've solved this.

The relevant code is:

if (!isset($_REQUEST['sort']) and isset($_REQUEST['edit']['sort'])) {
    $_REQUEST['sort'] = $_REQUEST['edit']['sort'];
}
if (!isset($_REQUEST['order']) and isset($_REQUEST['edit']['order'])) {
    $_REQUEST['order'] = $_REQUEST['edit']['order'];
}

$form = array();
$form['#method'] = 'get';

$form['sort'] = array(
    '#type' => 'hidden',
    '#value' => $_REQUEST['sort'],
);
$form['order'] = array(
    '#type' => 'hidden',
    '#value' => $_REQUEST['order'],
);

This saves the sort and order information into the form, and when the form is received, if there is no overriding sort information, it copies it back to where tablesort_sql expects it to be.

There should be a better way to do this...

Hi! I'm not sure what could be causing this. Did you go to the settings for site user list and set things up? What exactly do you try to do?

Thanks,
Ricky

Hi! This seems to be related to the use of clean urls. Specifically, if you have them turned off, it doesn't work.

I need to look at this a bit more. For right now, if you can enable clean urls, that will solve the problem.

Ricky

I've just committed a change that should solve this. The problem was that with clean urls off, the 'q' information (used by Drupal to specify where you're going) was getting stomped because I'm passing parameters via GET. I discovered (and was informed about) '#name' in the process of trying to solve this, which is actually exactly what I was looking for earlier. I now set '#name' for 'q', 'sort', and 'order' so that they don't have 'edit[]' wrapped around them, and thus life is happy.

Ricky