Hi,

First, thanks so much for this module. I've just moved some sites to site5.com, which provides nice support for mailman. So I'm dropping other massmailers and this module is just the ticket. The cvs version I started with mostly works under Drupal 4.7.4, but I think I've sorted out a couple minor rough edges. I've attached my modified module. Sorry I haven't documented the changes better. I'm a hacker, not a pro.

Here are my notes on changes and comments, in no particular order.

1. Table creation needs to add the db_prefix
Fixed. Replace '' by {} in .install file

2. with authorized but, non-admin user when you go to:

http://www.yourdomain.com/user/3/edit/mailman_manager

you get:

Warning: Invalid argument supplied for foreach() in
/home/ztnewsco/public_html/drupal/includes/form.inc on line 356

Seems to be a permissions issue.

Workaround - Be sure to set the permisions for roles you want to access mailman_manager. Ideally there should be a 'you don't have permission' message, but I haven't done that.

3. When logged in as an admin

http://www.yourdomain.com/user/1/edit/mailman_manager

should NOT show the "delete" button at the bottom! One MIGHT think it
means unsubscribe, but it means DELETE THAT USER!! Very bad. I'm just
glad I had a backup!

Workaround: DON"T HIT THAT DELETE BUTTON LIKE I DID!!!!!

4. Also, keep in mind the table in drupal can't know if the user has actually confirmed that they are a subscriber or not. So Drupal & Mailman can get out of syn, if your mailman users make changes using the mailman interface.

6. Digest vs. All Mail options look like they are reversed. I switched them so they work as I expected.

Fix: changed a 'case 2' to 'case 3' and vice-versa

7. I modified some of the instructions users see when the go to mailman_manager. Seems a bit more clear to me, your milage may vary

CommentFileSizeAuthor
mailman_manager-ztnews1.tar.gz10.85 KBcvining

Comments

arturoramos’s picture

Assigned: Unassigned » arturoramos
Status: Active » Postponed

The inversion of "all mail" and "digest" options has been fixed in the newest release.

The permission issue is related to not setting permissions after install. Authenticated users should be given "access" rights in order to avoid this error. I will write an instructions file with next release to address this critical installation issue.

The delete button is part of the user core module (whose hook this module uses) and therefore cannot be eliminated without changing the core. Please note that the button only appears to users with administrative privileges and not to the users themselves.

arturoramos’s picture

Status: Postponed » Closed (won't fix)

The delete button is part of user module and cannot be altered as such. It appears only in Admin mode so users cannot delete their own accounts.