CVS edit link for juankvillegas

I'm working in an e-commerce website using Drupal with Ubercart. As in this moment doesn't exists a Colombian Merchant Account supported by Ubercart, I decided to integrate PagosOnline and, in fact, they are checking the module developement.

The project name is uc_pagosonline.

Comments

juankvillegas’s picture

Status: Postponed (maintainer needs more info) » Active
StatusFileSize
new19 KB

I've attached the module files.

juankvillegas’s picture

Status: Active » Needs review

I forgot to mention that in the module adds an Ubercart Payment Gateway and an Ubercart Payment Method.

The Payment Method uses the normal PagosOnline's connection, it means that the user is redirected to PagosOnline page to finish the payment. The integration to make the payment from the Drupal website through PagosOnline's webservices will be implemented in the future.

avpaderno’s picture

Issue tags: +Ubercart, +Module review

Hello, and thank you for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

avpaderno’s picture

Status: Needs review » Needs work
  • The points reported in this review are not in order of importance / relevance.
  • Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
  • Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account.
  1. The version line needs to be removed from the .info file.
  2. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how Drupal variables, global variables, constants, and functions defined from the modules should be named.
  3. License files cannot be committed in Drupal.org repository. Projects committed in Drupal.org repository have the same license used by Drupal.

The module would be good, if it would not be for points #2, #3. Once those points are fixed, this module will get my approval.

juankvillegas’s picture

Status: Needs work » Needs review
StatusFileSize
new13.49 KB

Thank you for your comments. I've done the changes you suggested.

juankvillegas’s picture

StatusFileSize
new13.77 KB

Attached a new version with more implementations.

juankvillegas’s picture

StatusFileSize
new14.35 KB

Here is an updated version.

juankvillegas’s picture

StatusFileSize
new15.33 KB

I found a bug when a transaction response has some specific values.

juankvillegas’s picture

StatusFileSize
new16.64 KB

Here is the finished version. Including the Spanish translation.

juankvillegas’s picture

Status: Needs review » Needs work

I always thought that I was receiving warnings from Coder module caused by a Coder bug. But now I know what is happening and I'll fix it tomorrow.

juankvillegas’s picture

Status: Needs work » Needs review
StatusFileSize
new18.21 KB

Ok, here is the final version.

ojardila’s picture

Thanks so much. Great module.

juankvillegas’s picture

You're welcome.

avpaderno’s picture

Assigned: Unassigned » avpaderno
Status: Needs review » Fixed
juankvillegas’s picture

Thank you kiamlaluno. I see that you have been working very hard today to check a lot of CVS applications. People like you make Drupal bigger.

Thank you again.

moshel’s picture

Assigned: avpaderno » moshel

hombre, dejeme felicitarloprimero que todo por este modulo hace rato lo estaba buscando , sin embargo quiero preguntarle como hacer para que por ejemplo en el caso de uqe quisiera vender digamos un periodico entonces el usuario solo tendria que hacer click en cima de la imagen que diria compre su periodico aqui , me hago entender??.

agradezco su ayuda

alejandro ladino

avpaderno’s picture

Assigned: moshel » avpaderno
juankvillegas’s picture

Status: Fixed » Closed (fixed)
Issue tags: -Ubercart, -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Issue summary: View changes
Status: Closed (fixed) » Fixed
Issue tags: -Ubercart

I am giving credits to the users who participated in this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.