Two servers, one podcast

Humm... I seem to remember someone (WSUM?) had a script that uploaded the mp3s via FTP to another server. Take a look in the radio group on g.d.o and see if you see anything.

Oh, so had some time and found the thread on g.d.o: http://groups.drupal.org/node/8475

One thing to take from that is that you should use the existence of a .cue file as a signal that the rip is still in progress.

Why bother doing it in the shell? Just fork the ripper.php and add some exec() calls to do the scp-ing from there...

Perhaps we could make it more general and add two options to the ini for pre and post rip commands to run? That would be the Drupal way...

The idea is right but it needs a little clean up.

Please remove your site specific changes from the .ini file:

@@ -2,13 +2,13 @@
 ; These are the settings for the stream ripper script.
 
 ; Complete URL of webstream to rip
-stream_url = "http://127.0.0.1:8000/high"
+stream_url = "http://peace.str3am.com:6440"
 
 ; Full path to the stream ripper executable, version 1.61.17 or higher.
-streamripper_path = "/usr/local/bin/streamripper"
+streamripper_path = "/opt/local/bin/streamripper"
 
 ; Full path to station archive module's import directory (no trailing slash)
-import_path = "/usr/local/www/drupal/sites/all/modules/station/archive/import"
+import_path = "/Users/RickHeil/Desktop"
 
 ; Because shows tend to start early or finish late, the overlap_seconds
 ; setting allows you to determine how much the recording should overlap at the

I'd add a bit more to the pre/post-rip command comments mentioning that multiple commands can be separated by semi-colons:

@@ -19,3 +19,11 @@ overlap_seconds = 60
 
 ; The file type of the stream; "mp3" and "ogg" are supported.
 file_format = "mp3"
+
+; Pre-rip command - command(s) to be executed before the ripping starts. This is meant
+; for shell commands, this won't parse PHP.
+prerip_command = ""
+
+; Post-rip command - command(s) to be executed at the end of the ripping script. This is meant
+; for shell commands, this won't parse PHP.
+postrip_command = ""

I'd change the pre-post command to only execute if there's a setting:

if (!empty($settings['prerip_command'])) {
  exec($settings['prerip_command']);
}

Also it's not required but if you checkout the source from CVS you can use it to generate a single patch file.

Looking a lot better only two small things at this point:
- There's a tab used to indent the exec() lines. Drupal's coding standards call for using two spaces to indent.
- I think you could simplify the test before calling exec() as i outlined in comment#13.

Oh, wanted to add that we're excited to have you contributing. It's all about starting small, my first patch changed a single line: #34031: Delete button on the edit user account form should be after the submit button

The thing is that you're adding in another variable $postrip_command that really doesn't do much besides duplicate the value of $settings['postrip_command']. You can check existence and exec($settings['postrip_command']) directly rather than adding a second variable. Also "{$postrip_command}" is actually a bit wasteful. You're doing string replacement to extract the value of the variable. You could just use $postrip_command without bothering with the quotes.

This is what I'd meant.

Committed to HEAD (with some changes to the line wrapping on the comments).