I had to implement my own functionality so I could override the $disallowed_values_regex to allow url() in some cases. In the event that the property is a full url (say http://example.com/image.gif), the value is not going to survive since there is also a colon in it. I got something back than like "property: url(http;" and that's it :)

Patch attached does an array_shift first and uses implode after that so url can survive.

CommentFileSizeAuthor
#3 _ctools_css_disassemble_declaration.patch914 bytesswentel
#2 _ctools_css_disassemble_declaration.patch1.01 KBswentel
_ctools_css_disassemble_declaration.patch1.01 KBswentel

Comments

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs review » Needs work

good catch.

test? http://github.com/sdboyer/ctools/blob/sprint-master/tests/css.test

swentel’s picture

swentel commented
Status: Needs work » Needs review
StatusFileSize
new _ctools_css_disassemble_declaration.patch1.01 KB

Alright, by creating the test, I saw my original patch was actually not working fully. Imploding on '' instead of ':', stupid me.
Attached here is a patch for D6.

Tests for D7 + small fix are committed on my github fork* and pull request is sent to the sprint-master branch of sdboyer.

* see http://github.com/swentel/ctools/blob/sprint-master/tests/css.test and http://github.com/swentel/ctools/blob/sprint-master/includes/css.inc

swentel’s picture

swentel commented
StatusFileSize
new _ctools_css_disassemble_declaration.patch914 bytes

Reroll, using explode with limit.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Thanks! Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.