invoice_uninstall() should perform variable_del for each variable created in the module.

CommentFileSizeAuthor
invoice.install.patch900 bytesjbnewman

Comments

pietervogelaar’s picture

Assigned: Unassigned » pietervogelaar
Status: Needs review » Closed (fixed)

Thanks, It's fixed in the development version now.

Pieter

jbnewman’s picture

Status: Closed (fixed) » Needs work

The fix you implemented deletes all variables named "invoice_%". Unfortunately, because of drupal's lack of "good" namespace standards in the variable deck, this won't work as expected. If I were to create a module named "invoice_harmony", and roll it out, you'd delete all of my variables. :( I'm not aware of any way around this currently other than to track your variables and delete them individually.

At the very least, you probably should confirm that no other modules are installed with a name for which you would conflict.

-jbn

pietervogelaar’s picture

You're right. I will fix it in the next release!

Pieter

pietervogelaar’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs work » Closed (fixed)

It's fixed for Drupal 7 now.

Pieter