for links like node/nid/delete if viewer permission is set to 'delete any content' and author permission is set to 'delete own content' no links are displayed for author, because viewer permission check is first and since it is rarely same user has permission to delete own content AND delete any content, no links are displayed.

idea is to check for author OR viewer permission, not author AND viewer permission.

i'm on it.

CommentFileSizeAuthor
#4 custom_links-fix_permissions_token_support-917360-2.patch1.12 KBhenrijs.seso
#3 custom_links-fix_permissions_token_support-917360.patch1.11 KBhenrijs.seso
#2 custom_links-fix_permissions_token-support-#917360.patch1.11 KBhenrijs.seso

Comments

henrijs.seso’s picture

henrijs.seso commented

no, we just have to check if user is author or not, looks like an easy fix.

henrijs.seso’s picture

henrijs.seso commented
Title: permissions bug » permissions bug and tokens in permission names
Status: Active » Needs review
StatusFileSize
new custom_links-fix_permissions_token-support-#917360.patch1.11 KB

This patch will 1) fix permission bug 2) add token support for permission names. Making 2 fixes in same patch, because same code are responsible for both issues.

Bug was that code worked in viewer and author cases, but broke when viewer and author were same user. Now viewer permissions are checked seperatly - only for viewer if user is viewer (or 'NOT author' since there are only two cases) and only for author if user is author.

henrijs.seso’s picture

henrijs.seso commented
StatusFileSize
new custom_links-fix_permissions_token_support-917360.patch1.11 KB

changed patch file name without #.

henrijs.seso’s picture

henrijs.seso commented
StatusFileSize
new custom_links-fix_permissions_token_support-917360-2.patch1.12 KB

one line missed spaces in stead of tabs. sorry.

skizzo’s picture

skizzo commented

Patch #4 applies cleanly (before 927022.patch and 696302.patch) and fixes the bug. Thank you.