Next to the global "bypass mollom protection" permission, hook_mollom_form_info() additionally specifies further bypass permissions specific for a form. Right now, this information is only visible in code. We have to expose it.

Proposal:

mollom-bypass-permissions.png

Comments

Status: Needs review » Needs work

The last submitted patch, mollom-HEAD.bypass-access.0.patch, failed testing.

dries’s picture

- I think I like this patch. It is very helpful but it sorta puts a lot of emphasis on by-passing though. I'd recommend that we at least remove the by-pass information from the context sensitive help (i.e. "... unless they are able to ...").

- The list of permissions is not complete, is it? It does not mention Mollom's global by-pass Mollom permission?

wim leers’s picture

Subscribing.

The implicit bypassing when having the "Edit any [nodetype] content" permission has bitten me.

sun’s picture

Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs work » Needs review
StatusFileSize
new2.32 KB

New patch against D6.

Moved the list of bypass permissions from the overview page into the individual configuration form, since the list of permissions drew too much attention on the overview page.

Not completely happy about the label in the form ("Skip posts of users having the permissions:"), but I guess we can live with that for now. Better suggestions are welcome, of course! :)

dries’s picture

+++ mollom.admin.inc	29 Oct 2010 02:52:48 -0000
@@ -211,6 +213,32 @@ function mollom_admin_configure_form(&$f
+        '#title' => t('Skip posts of users having the permissions'),

I'm not 100% on this description. Technically, having one of those permissions is enough. Second, we're not skipping the posts, we're skipping Mollom. To be correct we'd have to write:

"Skip Mollom for users that have any of the following permissions."

That is a long title. I think we could create a short title like "By-pass Mollom permissions" -- I'd think it is self-explanatory.

sun’s picture

StatusFileSize
new15.74 KB
new2.41 KB

How about this?

mollom-bypass.png

sun’s picture

StatusFileSize
new4.21 KB

Added tests.

Noyz’s picture

Sorry, I can't read all the comments, so I'll just give you a heuristic review of the last screenshot...

1. Protection mode is clear. I get it.
2. When a post is blocked I'm not so clear on.
A. Is this telling me "when protection mode works, do one of these things"? If so, that could be more clear.
B. Of the choices, discard means what? Is discard delete?
3. Text fields to analyze. I get this, but it feels like its out of order. Seems like step 2. That is...
A. How do you want to protect, what do you want to protect, what do you want to do when protection works.
4. Bypass access permissions. I have no idea what this is doing. It doesn't seem actionable. I think it's informational and relating to item 1. That is.. "How do you want to protect? Regardless of what you choose, these protection rules are in place. I also think it could be more clear as...

Protection is not enabled for these permissions (link permissions to Permissions):
• Bypass Mollom Protection
• Administer Nodes
• Edit any story content.

sun’s picture

StatusFileSize
new15.58 KB
new5.85 KB

Thanks for the review! I've incorporated your suggestions:

mollom-bypass.png

sun’s picture

StatusFileSize
new15.42 KB
new8.25 KB

Some further tweaks:

mollom-bypass.10.png

sun’s picture

StatusFileSize
new8.26 KB
new15.5 KB

Final tweaks:

mollom-bypass.11.png

dries’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed to DRUPAL-6--1. Great job, sun. Let's sync up D7.

sun’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new8.19 KB

Contains two @todos for D7 core. :-|

Status: Needs review » Needs work

The last submitted patch, mollom-HEAD.bypass.13.patch, failed testing.

sun’s picture

Status: Needs work » Needs review
StatusFileSize
new8.9 KB

oh yay! Last patch revealed a different bug in the Contact module integration.

sun’s picture

For reference: The two Drupal 7 core issues mentioned as @todos in this patch:

#960490: Regression: ul.links generated by theme_links() always appears as .inline
#98696: Various bugs in theme_links()

I wonder whether it would make sense to create a dedicated issue in the Mollom queue to track all of the Drupal core issues that we need fix? Would have to grep through the module myself to figure out the status of those @todos and issues.

sun’s picture

Status: Needs review » Fixed

Thanks for reporting, reviewing, and testing! Committed to HEAD.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 5756cb7 on master, fai6, 8.x-2.x, fbajs, actions by sun:
    #917544 by sun: Fixed administrators are not aware of additional bypass...

  • Commit 5756cb7 on master, fai6, 8.x-2.x, fbajs, actions by sun:
    #917544 by sun: Fixed administrators are not aware of additional bypass...