Closed (fixed)
Project:
Mollom
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Sep 2010 at 21:51 UTC
Updated:
24 Apr 2014 at 17:13 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
dries commented- I think I like this patch. It is very helpful but it sorta puts a lot of emphasis on by-passing though. I'd recommend that we at least remove the by-pass information from the context sensitive help (i.e. "... unless they are able to ...").
- The list of permissions is not complete, is it? It does not mention Mollom's global by-pass Mollom permission?
Comment #3
wim leersSubscribing.
The implicit bypassing when having the "Edit any [nodetype] content" permission has bitten me.
Comment #4
sunNew patch against D6.
Moved the list of bypass permissions from the overview page into the individual configuration form, since the list of permissions drew too much attention on the overview page.
Not completely happy about the label in the form ("Skip posts of users having the permissions:"), but I guess we can live with that for now. Better suggestions are welcome, of course! :)
Comment #5
dries commentedI'm not 100% on this description. Technically, having one of those permissions is enough. Second, we're not skipping the posts, we're skipping Mollom. To be correct we'd have to write:
"Skip Mollom for users that have any of the following permissions."
That is a long title. I think we could create a short title like "By-pass Mollom permissions" -- I'd think it is self-explanatory.
Comment #6
sunHow about this?
Comment #7
sunAdded tests.
Comment #8
Noyz commentedSorry, I can't read all the comments, so I'll just give you a heuristic review of the last screenshot...
1. Protection mode is clear. I get it.
2. When a post is blocked I'm not so clear on.
A. Is this telling me "when protection mode works, do one of these things"? If so, that could be more clear.
B. Of the choices, discard means what? Is discard delete?
3. Text fields to analyze. I get this, but it feels like its out of order. Seems like step 2. That is...
A. How do you want to protect, what do you want to protect, what do you want to do when protection works.
4. Bypass access permissions. I have no idea what this is doing. It doesn't seem actionable. I think it's informational and relating to item 1. That is.. "How do you want to protect? Regardless of what you choose, these protection rules are in place. I also think it could be more clear as...
Protection is not enabled for these permissions (link permissions to Permissions):
• Bypass Mollom Protection
• Administer Nodes
• Edit any story content.
Comment #9
sunThanks for the review! I've incorporated your suggestions:
Comment #10
sunSome further tweaks:
Comment #11
sunFinal tweaks:
Comment #12
dries commentedCommitted to DRUPAL-6--1. Great job, sun. Let's sync up D7.
Comment #13
sunContains two @todos for D7 core. :-|
Comment #15
sunoh yay! Last patch revealed a different bug in the Contact module integration.
Comment #16
sunFor reference: The two Drupal 7 core issues mentioned as @todos in this patch:
#960490: Regression: ul.links generated by theme_links() always appears as .inline
#98696: Various bugs in theme_links()
I wonder whether it would make sense to create a dedicated issue in the Mollom queue to track all of the Drupal core issues that we need fix? Would have to grep through the module myself to figure out the status of those @todos and issues.
Comment #17
sunThanks for reporting, reviewing, and testing! Committed to HEAD.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.