Basket formatting error

Hi spa1969

Do you have any punctuation in your product's name? I was getting this from an item with "50:50" in its title. When I removed the colon, the error went away. Put it back, it reappears. Place a colon in another (previously working) product's name and the error surfaces again. I haven't tested this with any other non alphabetical characters, but it might be a parsing error caused by the colon somewhere.

Regards

Colin

Thanks for the updates - I think the module should be able to handle having a colon in the product title though, so I'm setting this to "active" again.

One of the fields of data sent to Sagepay when registering the transaction is "Basket", which is supposed to contain details of the customer's order for use in "My Sagepay"... It's an optional field so if it's causing a problem then it could be removed completely.

I had assumed that this information would get displayed to the customer at some point but examining the Sagepay Server integration documentation more closely, it does imply that it's just for the benefit of whoever is administering the Sagepay account.

Any way, the Basket field has to conform to a convention:

The shopping basket contents can be passed in a single, colon-delimited field, in the following format:

Number of lines of detail in the basket field:
Item 1 Description:
Quantity of item 1:
Unit cost item 1 without tax:
Tax applied to item 1:
Cost of Item 1 including tax:
Total cost of item 1 (Quantity x cost including tax):
Item 2 Description:
Quantity of item 2:
....
Cost of Item n including tax:
Total cost of item n

So I guess the colons in the product name are breaking the formatting of the Basket field.. Sagepay interprets them as field delimiters.

I think the solution is probably to have this module strip colons from product names before populating the Basket field - so that way people can use whatever product names they want.

Should be pretty easy to implement... will try to fix in the next day or two.

As I've just found out (the hard way) this bug is still present in the latest stable and dev version.
Here's a quick patch, which fixes the error for me.

I think this issue extends to other fields sent to Sage Pay. I've seen errors such as "Invalid characters in postcode". This is more of an issue because the customer doesn't get to see what the problem is, they just get redirected back to the order submission screen with no errors.

I think we need to strip more characters than are currently, from all fields, before sending the request to Sage Pay. I don't know what the set of allowed characters is, or what characters had been entered in my postcode field to cause the problem for me.

Thanks - I have added the patch at #5 to the dev version, please try it out.

Also, @deimos, your point noted - I just want to get the patch at @5 out the door while I'm here and without further ado but intend to check back on this next chance I have

Hi all, just confirming that the patch at #5 works for me.

Fixed in 6.x-1.5