Download & Extend

SQL-Statement doesn't return max-/minnodes values for non-role-members

Project:Shoutcast Streaming Server Statistics
Version:master
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

The SQL-Statement in nodelimit_max_for_user() doesn't return any values if the user is not member of a role.

When I changed the statement from
$query = "SELECT max(nl.maxnodes) as maxnodes, min(nl.maxnodes) as minnodes FROM {nodelimit_types} nl JOIN users_roles ur WHERE (nl.role=ur.rid OR nl.role=2) AND ur.uid=%d AND nl.nodetype='%s'";
to
$query = "SELECT max(nl.maxnodes) as maxnodes, min(nl.maxnodes) as minnodes FROM {nodelimit_types} nl JOIN users_roles ur WHERE ((nl.role=ur.rid AND ur.uid=%d) OR nl.role=2) AND nl.nodetype='%s'";
it seemed to work, but I'm no SQL-guru, so please have a close look at it.
Patch attached.

AttachmentSize
nodelimit.module-diff-2006-10-29-13-20-40.patch991 bytes

Comments

#1

Hey, I couldn't find this line anywhere in the code to be replaced.
???

#2

Project:» Shoutcast Streaming Server Statistics
Version:HEAD» master
Status:needs review» closed (fixed)
nobody click here