Load MusicBrainz data during node creation

I guess it could be done with hook_nodeapi($op='presave'). Want to take a crack at it?

To address that you can use isset()/empty(), and only load MusicBrainz if the field is empty.

Marking for me to go over later today.

Hum, yeah I feel like it wasn't getting enough hits against albums we were using. I'd just manually called those functions from a batch import I was doing. I'm curious if it would make more sense to have an AJAX-ish way of calling this and letting the user pick which data to use.

Patched this against CVS. Got the following error with an album that isn't in MusicBrainz yet:

user warning: Duplicate entry '2' for key 2 query: INSERT INTO station_catalog (nid, number, artist, album, year, label, mb_release_id, asin) VALUES (7, 2, 'Ion Dissonance', 'Cursed', 0, '', '', '') in /webroot/wonypod/includes/common.inc on line 3528.

Got the following error when adding an album that IS in MusicBrainz:

user warning: Duplicate entry '0' for key 1 query: INSERT INTO station_catalog (nid, number, artist, album, year, label, mb_release_id, asin) VALUES (0, 4, 'Ion Dissonance', 'Minus the Herd', 2007, 'Century Media', '4eeba3e1-8100-4940-ba8f-b0755aa94d0b', 'B000PAAI0W') in /webroot/wonypod/includes/common.inc on line 3528.

So, it is fetching okay, but something is getting hung up trying to insert the grabbed data.

Latest patch works without error, but I agree the delete and re-save feels a bit dirty.

I like where this is going but it still needs some work. The more I think about this I think it might be better to allow the user to trigger this functionality by adding a submit button that would fetch the data from MusicBrains. Take a look at the button on archived audio nodes to reload the scheduled info for an example of what I'm talking about.

We should drop the db_query(INSERT/UPDATE) in favor of drupal_write_record(). it'll let us drop several lines of code and look a lot cleaner.

It would be good to provide some comments explaining why we're looking where we're looking for the album's release year.

The PHP Docs for station_catalog_musicbrainz_set_album() need work, please review the Doxygen formatting conventions. I'm also not super into the name it's not really clear what it does. Maybe something like station_catalog_update_album_from_musicbrainz()? something like that?

Seems like there might be some unrelated changes in here. I'm not seeing the need for:

+  if ($node->revision) {

on this specific issue. If we want to change that I think it'd be best to do it in its own issue so we can look at the other sub-modules and make the change consistently.

Would love to get the docs explaining the ordering of these tests:

+      if (strlen($release->$event->event['date']) == 4) {
+        $ret['year'] = (string) $release->$event->event['date'];
+      }
+      elseif (preg_match('/.*US (\d{4}).*/', $release->$event->event['date'], $matches)) {
+        $ret['year'] = (string) $matches[1];
+      }
+      elseif (preg_match('/(\d{4})-\d{2}-\d{2}/', $release->$event->event['date'], $matches)) {
+        $ret['year'] = (string) $matches[1];
+      }

In that case it might be easiest to use a Date module field. I've been trying to move station into CCK fields. Now that Features module is so far along it might make sense to "featurize" the station modules.

Any plans to "Feature" the station modules for D7?