Hi,
Thanks for sharing this module.

There is a typo error on hotel_booking.theme.inc
Line 178, 179, $modifier->hoid don-t exist, it must be $modifier->hbomid :

      l(t('Edit'), 'admin/store/hotel_booking/occupancy_modifiers/'. $modifier->hbomid) .' | '.
      l(t('Delete'), 'admin/store/hotel_booking/occupancy_modifiers/'. $modifier->hbomid .'/delete'),

Regards.
Mog.

CommentFileSizeAuthor
#2 uc_hotel_date.patch2.12 KBmogtofu33

Comments

mogtofu33’s picture

And some other typo corrections :
hotel_addons_upgrades_admin.inc
line 57, 58, need t()

  $addon_products .= l(t('Configure New Upgrade/Addon Product'), 'admin/store/hotel_booking/upgrades_addons/add'). ' | ';
  $addon_products .= l(t('Limit Available Upgrade/Addon Product Classes'), 'admin/store/hotel_booking/upgrades_addons/settings');

line 182, need t()

    $option_list = array('0' => t('-- Please make a selection --')); }
mogtofu33’s picture

StatusFileSize
new2.12 KB

I think you could set some improvments on language managment, in some case it's better to use format_date() instead of date() because it can handle format and localization. Sometimes you use t() function in a wrong way to replace variables on text (see : http://api.drupal.org/api/function/t/6), it's better to use strtr() or nothing if localization is handle by fromat_date();

Here is a patch.

Regards.
Mog.

larowlan’s picture

Assigned: Unassigned » larowlan
Status: Active » Reviewed & tested by the community
Issue tags: +Release blocker

Thx
I think the hmoid one is fixed in dev, could be wrong
Thanks for picking up the t on add ons module.
I didn't write it (the addons module) but intend to rewrite it so it uses FAPI forms for the selection screen (I don't like it as is - doesn't let other modules modify it with hook_form_alter etc). These changes will go in with that.

laraz’s picture

thanks.