EU vat display

I created a patch for latest head that displays the following :

Subtotal incl vat
Shipping cost including vat
Total excluding vat + Shipping Costs excluding vat (proportionally calculated on cart items)
Vat splitted by tax rates (in germany we have 7% and 19% for example)
------------------
Total including vat

Maybe you'll review / try this patch ..

Patch was created against latest DEV Version (2010-Sep-21)

I added this little feature also to the attached patch. I don't know if it's the best way to reach this approach - but it works ;).. There is still a problem when deactivating the option "Show shipping costs without !tax as new line item" cause shipping costs w/o tax is added as a new line item in order_line_item table.
Maybe someone knows a better way to solve this problem..

Just have a look at the screenshot - i think this solution would fit your needs .. ( and is still understandable by a client :-) )

SteffenR

I should have looked at this before rolling my own code :) !

FYI-- you're further than me but I had a few issues with getting it to work here (EN site set for Slovenia as location). I'll try to clean up/review and deal with the column issue etc-- if you see this, let me know if you're also working on so we don't overlap.

Plus I trust nicjasno will help us with providing Slovenian translation (Moja slovenščina ni zelo dobra.)

Hello again SteffenR,

Thanks again for this code and the work.

I've altered the code only slightly but will attach-- primarily, I've 1) removed the & $term reference structure which you've added in some places (it should work-- but might not-- and differs from the HEAD version) in ~.module and 2) normalized your code back to the HEAD where it differes, so it does not show diffs in places where there are no meaningful code differences.

I doubt #1 will solve your tables problem, alas, unless you were trying to do something though the reference that I didn't catch.

All that said, here's my comment after reviewing the code.

I would have added a selection variable option (as you do).

That done, I would not have added a line to the table. Since the VAT portion of shipping is a straight scalar calculation from shipping & VAT, I would have simple altered the form to display this based on the selection variable option and the existing variables. No need for another storage variable that is nothing but existing variables multiplied by each other!

I suspect the best solution lies somewhere between my quick approach, and yours, and look forward to your thoughts on the matter.

Best, yours,

Ken

P.S. Someone please let me know if I've flubbed anywhere in the code; patches are against current -dev.

Hello Ken,

your patch worked flawlessly for me. Steffen and Ken thanks a lot for your work.

Bye
Rene

Hi Nic,

In case you don't know- please note that priority is for the module maintainers to assess the impact of an issue on all module users. However I think you've absolutely correct that this is "major" for EU/Schengen Area users.

There is a checkbox, but it doesn't quite work as expected-- sorry I didn't catch you over the weekend to find if that was critical to you. I'll be fixing that and order as I can right now.

@SteffenR:

I'm going to try to simplify this right now, and give you some code that avoids the table issue. I hope I'm not overconfident in that.

Thanks all,

Ken

I don't really want to special case shipping costs in the uc_vat code, though I can see the need to proportionally recalculate tax on shipping. If other line items are included in the order total (uc_pma, uc_fee, etc.) shouldn't they also be displayed ex-VAT in the same way?

Hi longwave,

Thanks for the reply. I'm not sure if _pma and _fee are subject to the same regulatory necessity as shipping, but am glad for suggestions on how to implement in a simpler or "best" manner.

Thanks,

Ken

I am trying to find the legislation that says we must show VAT exclusive prices on invoices; in the UK this does not seem to be necessary, but perhaps there are different invoicing rules in other member states.

http://ec.europa.eu/taxation_customs/taxation/vat/traders/invoicing_rule... point 12 says invoices must include "the unit price of the goods or services exclusive of tax, discounts or rebates (unless included in the unit price)" - so can't we just note that tax is included the unit price for products, shipping or other line items?

The HMRC site has easier to understand guidance for the UK at least: http://www.hmrc.gov.uk/vat/managing/charging/vat-invoices.htm

As I understand it, uc_vat currently outputs a correct "modified VAT invoice" but not a "full VAT invoice", which is generally accepted in the UK. Is this not allowed in other EU member states?

This is an interim version (attached) which mostly deals with weighting / display issues brought up by nicjasno, and adds some direct db calls because weighting cannot be set with current functions.

IT IS LIKELY ONLY OF INTEREST to EARLY ADOPTERS.

Thanks.

@
longwave:

I think nicjasno will need to answer that, I've let him know. (Also: Sorry, don't know why that changed status, setting back).

In France, shipments with the National Post, using normal rates, DO not include VAT.

On the other hand:
* Some Shipments with the National Post with tracking, like Colissimo parcel wth tracking or Chronopost, include VAT. These are very common shipments.
* In any case, you may decide of a shipment cost. If the shipment cost includes a special service, it should include VAT.

Sometimes I saw this kind of invoice, with two lines:
* Preparation of shipment: 2€, inclu. VAT
* Shipping with National post : x€, exclu. VAT

This is quite complicated.
My personal opinion is that Ubercart comes to a point when it needs accounting underlying bases.

@jmpoure: in Germany you have the same issue with "Deutsche Post" - they own the unique position to have shipping costs without tax - all the other shipping"providers" have taxes on their shipping costs.

In this case it would be better to extend the capabilities of the shipping module - maybe a "simple checkbox and some calculation logic would be enough" ;)..

The new "Apply VAT to shipping at the highest rate used in products in an order" option goes towards solving this for the UK case, but does not fully handle the case where stamps bought from Royal Mail should not be taxed (and you might have a separate handling charge added on top of this!)

I suggest using uc_fee to provide a separate handling charge (if needed) and taxing that as appropriate, and I think we can add a Conditional Actions rule to apply tax to shipping only for specific shipping methods - does this sound like a workable solution?

Marking fixed, as I think the order total preview in columns in the latest -dev should solve the ex-VAT/VAT/inc-VAT display issues at checkout, and the proportional shipping VAT is now implemented.

As this issue is a bit confused with several things going on (line item display vs shipping VAT rules) please open a new issue if there are further problems in -dev.

Re-opening, self-assigning.

Displays correctly in-cart but there is no display in check-out. For accounting / regulatory purposes, it must display on check-out and in the invoice.

I'll try to work up a patch to fix.

De-self-assigning since a number of parts of the module seem to have changed more than I expected since I last looked at this.

I add an extra line item to the order in _uc_order, may still be a viable approach. Will come back to this later if I find the time.

NOTE: my patch, above, will no longer work AFAIK with current uC.