Why does (In Press) show after Source in detailed view?
glendac - October 29, 2006 - 22:17
| Project: | Bibliography Module |
| Version: | 4.7.x-1.x-dev |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
See for example http://cms.softtester.org/drupal/node/25
I've tried to look at the code in the biblio.module and this may be the relevant section:
if (!isset($node->biblio_year)) {
form_set_error('biblio_year', t('You must supply the year of publication'));
} else {
$today = getdate();
if (($node->biblio_year == t("In Press")) or ($node->biblio_year == 0)) {
$node->biblio_year = 0;
}
elseif ($node->biblio_year < 1900 || $node->biblio_year > $today['year']) form_set_error('biblio_year', t('Year of Publication must be a number between 1900 and ' . $today['year']));
} But I'm no programmer and I'm afraid to tweak it 'coz I might make things worse. Thanks for any help.
Glenda
#1
Hi Glenda,
In Press is showing because the publication is year is set to 0 (zero), and it appears that there is no data at all for those entries. I'll have to add some checks so that entires like these simply won't show up in the list. Better yet they should have never been created in the first place so I'll have to go back and look at the code to see why, if the parser wasn't included, a node was created in the database anyway. This shouldn't have happened.
Ron.
#2
Oppps, sorry I just noticed that (In Press) is showing up on all entries. Obviously the patch I put in there last week for the "In Press" entries has a little bug. I'll fix that tomorrow.
Ron.
#3
I just found and fixed the bug. If you get a new version of the module, it should show
"biblio.module,v 1.13.2.22 2006/10/30" as the version at the top of the file. I also removed the redundant slashes in the include path for the parsers so hopefully this one file will fix both of your problems.
Ron.
#4
I've downloaded the newest version and this In Press issue is now resolved! [Though my import issue still needs a solution:(] Thanks Ron!
Glenda
#5