vadim.eremeev [vadimeremeev]

Hello, and thank you for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site; for modules, it should include also a comparison with the existing solutions.

Remember to change status, when you upload a new version of the code.

• The points reported in this review are not in order of importance / relevance.
• Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
• Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account.

1. The module doesn't implement hook_uninstall(), or doesn't implement it to remove the Drupal variables it defines.

2.     'review'   => $payment_types[$_SESSION['payment_type']] . t(' via smoov'),
   
   

   Use t()-placeholders.

3.     'desc'     => t('Redirect to smoov to pay by credit card .'),
   
   

   There should not be spaces, before a period.

4.             $details .= '<input type="radio" name="payment_type" value="'. $key .'"'. (($type == $key) ? $selected: '') .'>'
                           . _uc_smoov_payment_type_info($key, $val) .'<br />';
   
   

   Form fields are created using the form API.

5. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how the code should be formatted (and the indentation to use).

6. function _uc_smoov_payment_type_info($type, $name) {
     $path = drupal_get_path('module', 'uc_smoov') .'/images/mastercard.gif';
   
     return '<img src="'.$path.'" style="position: relative; top: 6px; margin-right: 5px;">';
   }
   

   There is a Drupal theme function to use for images.

Please read all the following and the links provided as this is very important information about your CVS Application.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:Migrating from CVS Applications to (Git) Full Project Applications.

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.

As per previous comment, I am setting this issue as Won't fix.
Since new users can now create full projects, applications have a different purpose and they are handled on a different issue queue. See Apply for permission to opt into security advisory coverage for more information.