unset form values, such as radio buttons improperly trigger 'An illegal choice has been detected'

This is also an issue for Drupal 7.x. This example form illustrates the problem:

/**
 * Data import form.
 */
function my_custom_import_form($args) {
  $form = array('#attributes' => array('enctype' => "multipart/form-data"));

  $form['upload_file'] = array(
    '#type' => 'file',
    '#title' => t('Data file'),
    '#required' => TRUE,
    '#size' => 40,
  );

  $form['upload_type'] = array(
    '#type' => 'radios',
    '#title' => t('Data file type'),
    '#required' => TRUE,
    '#options' => array(
      'product_csv' => t('Product CSV file'),
    ),
  );

  $form['submit'] = array(
    '#type' => 'submit',
    '#value' => t('Start import'),
  );

  return $form;
}

This form, if submitted without any filling any of the fields, yields a “An illegal choice has been detected. Please contact the site administrator.” in addition to the “Data file field is required.”. The appropriate error would be “Data file type field is required.”

@thekevinday: adding patch against HEAD.

also adding patch for d6 latest dev, to help #453204: Validation error produced by empty required conditional fields (radio buttons, checkboxes) for example.

I wonder what this could break.

Patch from #4 solved another problem I have with http://drupal.org/node/1081196#comment-4170278 (using Drupal 7.0).

I have also done test with custom form with required radio buttons but without default value.

  $form['radios'] = array(
    '#type' => 'radios',
    '#title' => t('Radios test'),
    '#options' => array('o' => t('Optional'), 'r' => t('Required')),
    '#required' => TRUE,
  );

  $form['submit'] = array(
    '#type' => 'submit',
    '#value' => t('Submit'),
  );

If I submit this form without selecting some radio option I will get 'An illegal choice has been detected' error. With patch from #4 error will be correct one 'Radios test field is required.'.

Subscribe.

subscribe

can anyone confirm that this patch works for D6.21 and D6.22, please?

Regarding the patch for the 6 version in #3 I think, could someone please explain how to apply it manually?

I have applied a few patches but can not figure out how to apply this through command line, and it looks manageable to apply manually.

Thank you.

? HEAD_919348_3.patch
Index: includes/form.inc
===================================================================
RCS file: /cvs/drupal/drupal/includes/form.inc,v
retrieving revision 1.511
diff -u -p -r1.511 form.inc
--- includes/form.inc	17 Nov 2010 04:10:51 -0000	1.511
+++ includes/form.inc	23 Nov 2010 21:54:33 -0000
@@ -1167,7 +1167,7 @@ function _form_validate(&$elements, &$fo
         form_error($elements, $t('!name cannot be longer than %max characters but is currently %length characters long.', array('!name' => empty($elements['#title']) ? $elements['#parents'][0] : $elements['#title'], '%max' => $elements['#maxlength'], '%length' => drupal_strlen($elements['#value']))));
       }
 
-      if (isset($elements['#options']) && isset($elements['#value'])) {
+      if (isset($elements['#options']) && isset($elements['#value']) && (!isset($elements['#required']) && !(!count($elements['#value']) || (is_string($elements['#value']) && strlen(trim($elements['#value'])) == 0)))) {
         if ($elements['#type'] == 'select') {
           $options = form_options_flatten($elements['#options']);
         }

Above is patch #3 (http://drupal.org/files/issues/919348_3.patch)

@@ -1167,7 +1167,7

above mean the code around line 1167

-      if (isset($elements['#options']) && isset($elements['#value'])) {

above mean you must delete this line

+      if (isset($elements['#options']) && isset($elements['#value']) && (!isset($elements['#required']) && !(!count($elements['#value']) || (is_string($elements['#value']) && strlen(trim($elements['#value'])) == 0)))) {
         if ($elements['#type'] == 'select') {
           $options = form_options_flatten($elements['#options']);
         }

above mean you must add this codes.

IMPORTANT: please make a copy before edit file!!!

Thank you drupal-id

My cpanel is having trouble saving modified files today for an unrelated reason so have not been able to try it yet, but thank you for the quick response.

Looks like for version 6 it is just replacing one line. Does this modify the Drupal core? I do not think I have done that before.

sub

I think there might be a conflct with conditional 6 3. dev and editable fields 6 3. dev, so I am going to stick with conditional6 2. beta for now.

I'm encountering the same bug, Drupal 7.2, not using Conditional Fields. When I try to "add another item" in a repeating text field, if a separate required radio field is not selected, it throws an "Illegal" error. Is the patch in #13 stable and going to be committed?

Thanks thekevinday for doing all that legwork!

The patch in #13 solved my problem. Tks!

This looks like a duplicate of #811542: Regression: Required radios throw illegal choice error when none selected which is seeing lots of core dev action on it.

Michelle

Subscribe

#4: 919348-unset-form-values.patch queued for re-testing.

We had the same issue, but the error was displayed when we click on an "Add more" button for a different form element.

Patch #13 resolves the issue for us.

#3: 919348_3-D6.patch queued for re-testing.

#811542-179: Regression: Required radios throw illegal choice error when none selected has a better fix for this.