Shipcalc calls get_rates once per item and then passes the whole transaction. Not causing a problem. Looks like the current partners are just doing a fresh calculation the shipping rates each time. The risk would be a large shopping list with many many calls to UPS/USPS etc.

CommentFileSizeAuthor
#2 shipcalc2.41 KBsime
#1 shipcalc-get-rates.patch2.11 KBnedjo

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
StatusFileSize
new shipcalc-get-rates.patch2.11 KB

Yes, this looks to be redundancy maybe left over from an early plan to fetch separate rates for each item.

Attached untested patch is an idea for how to address this.

sime’s picture

sime
any/any
Location Melbourne
commented
StatusFileSize
new shipcalc2.41 KB

Yeah, I'm liking this new design. My latest patch attached, not much different. I took out $form parameter on the method call cos it was messing with me.

sime’s picture

sime
any/any
Location Melbourne
commented
Status: Active » Patch (to be ported)

Committed nedjo's patch at #1 to HEAD
http://drupal.org/cvs?commit=51238

4.7 maintainers might like to backport.

Patch at #2 might still be relevant, but I need to refresh my mind and I'll follow up here.

brmassa’s picture

brmassa commented
Status: Patch (to be ported) » Fixed
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)