Add promotion/subscribed link results support

purdy_nc: Your XML example has an unexpected (to me) set of IMAGE elements in SL_MAIN which are not allowed for by the documentation, which is why I haven't implemented any support for that.

While I'm here, I noticed a few formatting glitches in the code -- a handful of tabs crept into the indentation, a "foreach(" with no intervening space, etc...

You might want to run it through the coder module.

I had unnecessarily included a couple of lines from google_cse_adv_block_suggestion() in my google_cse_adv_block_subscribed_links()

    $page = isset($_GET['page']) ? $_GET['page'] : 0;
    $response = google_cse_adv_execute(search_get_keys(), $page);

This is the same patch, with those lines removed (and the data variable name changed to $links).

On the topic of unexpected components in the XML, notice that I've provided the original XML in the data passed to the theme function, so themers can still process any XML components which the module did not expect to see.

I haven't made any similar changes to other parts of the module in this patch, but I would suggest this as a useful thing to do in general.

> Wow, that was fast, jweowu!

Pure coincidence, in fact :) I was just about to create the issue in order to attach my patch, and I found that you'd asked for the exact same thing since I'd last checked the queue. For a moment I thought your XML attachment was a patch, and we'd both just implemented the same thing.

So... that image stuff looks fairly official, doesn't it? I guess we just add support for the current XML, and hope it doesn't change.

FYI, if you've tested the patch and it all looks good to you, please say so. If you've reviewed the code as well, you might set the status to RTBC.

Hmm.. it's working fine for me with the exact same configuration. Can you verify that:

1) The promotion works correctly when searching via the google interface? (or check the XML being returned, as before).
2) The content top region is being rendered by your page template?

Now I just need to figure out how to get it to work inside of the results instead of in the content top.

sites/all/themes/(theme-name)/template.php:

/**
 * Pre-process variables for search-results.tpl.php
 */
function (theme-name)_preprocess_search_results(&$variables) {
  $promotions = google_cse_adv_block_subscribed_links();
  $variables['promotions'] = $promotions['content'];
}

sites/all/themes/(theme-name)/search-results.tpl.php:

print $promotions;

Perhaps this module should provide its block contents in this fashion by default, with a google_cse_adv_preprocess_search_results(), as a convenient alternative for themers?

Yes, I think that's a good idea. Perhaps a setting to turn on/off this feature and then both block is exposed together with a variable in preprocess? If you do that, I will be happy to commit the patch.