Meta Tags Checking Doesn't Work [#919618]

I'm using Nodewords 6.x-1.12-beta9 and it looks like the Nodewords folks may have broken your meta tags checking for this module. I found the problematic line. It's in keyword_rules.module, here:

 switch (variable_get('keyword_rules_keywords_driver', 'cck')) {
    case 'nodewords':
      $keywords = $form_values['nodewords']['keywords']['value'];
      break;

This needs to be:

 switch (variable_get('keyword_rules_keywords_driver', 'cck')) {
    case 'nodewords':
      $keywords = $form_values['nodewords']['metatags']['keywords']['value'];
      break;

I'm using version 2.1, but I see that the issue still exists in -dev, as well. I made this change in my copy and it works now.

Thanks for this module, BTW. It's simple enough for even my web design clients to understand. I only recently discovered it, but I love it.

Comments

Comment #1

miruoss commented 22 September 2010 at 20:57

Assigned:	Unassigned	» miruoss
Issue tags:		+nodewords meta tags

Hi Wayne

Thanks for the report and the solution. I will however have to wait for nodewords-6.x-1.12 to become stable before I can change this in my code. Who knows, maybe I have to create a new release before nodewords 1.12 gets stable and having this change in it would break the module for all people using 1.11.

Anyway this is good to know, it will help anyone who already uses the beta release of nodewords. And as soon as 1.12 gets stable I'll change the code and create a new release (might need a reminder though ;) )

Also thanks for the good feedback! :)

Cheers,
Michael

Comment #2

grabby commented 22 September 2010 at 22:10

I tried both 6.x-2.1 and 6.x-2.x-dev with jQuery Update 6.x-2.x-dev and jQuery UI 6.x-1.4, but no checks are done whether I preview, create or save a node. I have the Keyword Field Provider Module set to Meta Tags, since that’s where they were prior to me installing this module. Speaking of Nodewords, I’m using 6.x-1.11. I even tried the recommendation in the post above to no avail. I’d love to get it working, but could use some help doing so!

Comment #3

miruoss commented 22 September 2010 at 22:12

Status:

Active

» Needs review

Hi again

I decided to nevertheless change the code already but include a check of what version of nodeworks is installed. However, version 1.12 of nodewords is a bit more complex than 1.11 was. You can also define global keywords now. So the code now looks as follows:

 switch (variable_get('keyword_rules_keywords_driver', 'cck')) {
    case 'nodewords':
      if (function_exists('_nodewords_tag_value')) {
        # Using nodewords >= 6.x-1.12, let nodewords module do its magic...
        $keywords = _nodewords_tag_value(
          'keywords',
          isset($form_values['nodewords']['metatags']) ? $form_values['nodewords']['metatags']['keywords'] : array(),
          array('type' => NODEWORDS_TYPE_NODE, 'id' => $form_values['nid'])
        );
        $keywords = $keywords['value'];
      } else {
        $keywords = $form_values['nodewords']['keywords']['value'];
      }

This has been committed to CVS (6.x-1.x-dev and 6.x-2.x-dev). Still need to check 7.x version. Please check out the next development release.

Cheers,
Michael

Comment #4

miruoss commented 22 September 2010 at 22:15

Hi Grabby

Please have a look at #883288: No Checking is taking place on Page Node (both cck and meta tags is empty). If that doesn't help, please reopen that ticket with more specific details about your settings. (This ticket is just about nodewords 1.12 compatibility)

Michael

Comment #5

grabby commented 23 September 2010 at 03:53

Thanks Michael, I managed to overlook the need to enable the checking on the content types!?! Having said that, I installed today’s 6.x-2.x-dev version, but on the available updates page it’s registering as the July 11 version. Perhaps the info file needs updating as well?