The simple cache plugin uses t() for the '#type' of granularity

So by default no granularity will be saved so panels with arguments has a wrong caching by default so this panels display white sometimes when they should not :(

Comments

dawehner’s picture

StatusFileSize
new682 bytes

Here is the patch. What a facepalm

tobiasb’s picture

Status: Needs review » Reviewed & tested by the community
jcmarco’s picture

Status: Reviewed & tested by the community » Needs work

In the last commit: http://drupal.org/cvs?commit=437926

There is a big problem with the new cleanstring in the css field.
Now the pane custom css values are all linked instead respecting the configured ones, due to the new:
$content->css_id = ctools_cleanstring($pane->css['css_id']);

I mean, if I have set up the CSS class in the CSS properties of a pane as:
default_title dark title-F64B00 view-top-hot inner-lightblue-white
Now I get this in the html code:
default-title-dark-title-F64B00-view-top-hot-inner-lightblue-white

jcmarco’s picture

Status: Needs work » Needs review
StatusFileSize
new1.72 KB

Reading the documentation in ctools/includes/cleanstring.inc

I think that there is no way to have a field with custom css values and apply it the cleanstring,
because by default it changes spaces and untranslatable characters to '-' or whatever else:

* - 'separator': Change spaces and untranslatable characters to
* this character. Defaults to '-'.

So I would recommend to roll back part of the changes in this commit.

merlinofchaos’s picture

Um? jcmarco, you seem to have taken over an unrelated issue.

merlinofchaos’s picture

Formally: Ignore #3 and #4. Those belong in a new issue, not taking over a completely unrelated issue.

jcmarco: I assume this is just an error. The only reason you don't get an ear-full is because you've been around before and have earned some karma. =)

merlinofchaos’s picture

Oh I see now. I was confused, because I had forgotten that I had committed this patch, and that cleanstring patch went in as part of this accidentally.

merlinofchaos’s picture

Status: Needs review » Fixed

Ok, the cleanstring patch wasn't meant to be committed, so removed. That allows this to be marked fixed.

jcmarco’s picture

I realized that the issue subject was not related with the new issue, but the problem was created by a wrong commit on this issue. So I considered the best to attach it to the problem root, to ease the analysis.
Sorry for any inconvenience.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 3f555d0 on 7.x-3.x, master, pipelines, 7.x-3.x-i18n, 8.x-3.x by merlinofchaos:
    #920266 by dereine: Typo in cache.inc caused wsods in rare circumstances...