I have price editing incl. VAT enabled and a vat for blank line products. If you insert a blank line product it's the same price in the database like the price you typed in. But it must be a price less tax (net). Because of this the tax line is wrong.

CommentFileSizeAuthor
#4 uc_vat-taxable_blank_line_item-920678-4.patch3.09 KBabsoludo

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Looks like this could be an Ubercart core bug: #382674: Blank Line products can't be taxed

fmueller’s picture

fmueller commented

At admin/store/settings/taxes/add I checked '"Blank line" product' and 'Product' in the section 'Taxed product types'. In the section 'Taxed products' I choose 'Apply tax to any product regardless of its shipability'.

At admin/store/settings/taxes/vat the module uc_vat is configured so that the sell price is entered inclusive of vat.

I have an order with one article that costs 100 euro. At the page where I can edit this order I see the following:

Subtotal: 100,00€
Subtotal excluding VAT: 84,03€
19% VAT: 17,87€
Total: 100,00€

So far everything is ok. Now I edit this order and add a "Blank Line Article" with a price of 10 euro. Now I read this at the order edit page:

Subtotal: 110,00€
Subtotal excluding VAT: 94,03€
19% VAT: 17,87€
Total: 110,00€

Obviously there is something wrong because 94.03 + 17.87 is not equal to 110. When I deactivate uc_vat the "Blank Line Article" is taxed correctly. Is this a bug or did I misunderstand something?

I use Ubercart 2.4 and uc_vat 1.2.

absoludo’s picture

absoludo commented

I am running into a similair problem.
The blank-line option is checked in settings/taxes
Upgrading to UC3 is not possible at this moment.

Subtotal: €42,65
Shipping: €6,75 (This is ex VAT)
Subtotal excluding VAT: €41,99
21% VAT: €8,82
Total: €50,81
Everything

Subtotal: €52,65 (same order but with a €10 blank-line item, that's €10 incl VAT)
Shipping: €6,75 (This is ex VAT)
Subtotal excluding VAT: €51,99 (should be €50,25)
21% VAT: €8,82 (should be €10,55)
Total: €60,81 (is correct)

I cannot find any fixes online and patching the module has not proven productive so far.
I have tried overriding both the subtotal in uc_vat_line_item_tax_subtotal and the applied tax in uc_vat_product_price_alter.
Any suggestions/hints anyone?

absoludo’s picture

absoludo commented
Status: Active » Needs review
StatusFileSize
new uc_vat-taxable_blank_line_item-920678-4.patch3.09 KB

I managed to fix it in my specific installation, but am not to sure about the patch I created.
If anyone has this issue you can try and see if my patch helps.

I patched ubercarts uc_taxes module 6.x-2.11 and also patched uc_vat 6.x-1.2