In addition to the 'Label suffix' configuration, it would be great to have an option to add CSS classes.

Thanks for great functionality. Looking forward to see this module grow and get more used!

CommentFileSizeAuthor
#3 label-class-2.patch6.5 KBitangalo
#1 label-class.patch5.9 KBitangalo

Comments

itangalo’s picture

itangalo commented
Status: Active » Needs review
StatusFileSize
new label-class.patch5.9 KB

Well, well!

I think I'm learning how to do some module development. This patching thing is quite a good way to spend my time!

Attached is an attempt to introduce the suggested feature. It works at least on my installation. (Clean Drupal 6 with current dev of Semantic CCK.)

Cheers!

itangalo’s picture

itangalo commented

PS: I also took the liberty to (1) do a small addition to the help text for the label suffix fields, and (2) shorten the lines where _semantic_cck_setting_names is defined.

Test bot, please review!

itangalo’s picture

itangalo commented
StatusFileSize
new label-class-2.patch6.5 KB

Yeah, ok. Still learning.

The patch below is better. It includes classes for labels even for multipla-value fields.

rjay’s picture

rjay commented
Assigned: Unassigned » rjay

Hi Itangalo,

Thanks for your interest in Semantic CCK and for taking the time to create these patches. I'm not quite sure why we didn't have the option for a class on the field label when we created Semantic CCK, but it seems like it could be useful in certain cases.

I have made some minor modifications to your second patch, made some CSS changes to display the (now) three label options inline, and committed both of our changes to 6.x-1.x-dev.

Cheers,
Ryan

itangalo’s picture

itangalo commented

Yay! Thanks for including the patch!

rjay’s picture

rjay commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.