What the title says. Patch coming.

CommentFileSizeAuthor
#2 921144_field_filter.1.patch3.59 KBdawehner
#1 921144_field_filter.1.patch849 bytesyhahn

Comments

yhahn’s picture

yhahn commented
StatusFileSize
new 921144_field_filter.1.patch849 bytes

As seen in the data entry

      $data[$table][$column_real_name] = array(
        'group' => $group,
        'title' => $title,
        'title short' => $title_short,
        'help' =>  t('Appears in: @bundles', array('@bundles' => implode(', ', $bundles_names))),
      );

The handler currently tries to pass the human readable title to field_info_field() which obviously will not work. Patch fixes to use the title_short value.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 921144_field_filter.1.patch3.59 KB

I obvious used "test" for both title and the machine readable name :)


    if (count($field['columns']) == 1) {
      $title = t('@label (!name)', array('@label' => $field['field_name'], '!name' => $field['field_name']));
      $title_short = $field['field_name'];
    }
    else {
      $title = t('@label (!name) - !column', array('@label' => $field['field_name'], '!name' => $field['field_name'], '!column' => $column));
      $title_short = t('@label-truncated - !column', array('@label-truncated' => $field['field_name'], '!column' => $column));
    }

So title short is not secure from my perspective.

So i added field_name to every definition of fields/arguments/... This is better name. Additional it's secure to be the right one at any time.

Additional a bug in list_field_views_data was fixed to remove a unwanted field from the listing.

yhahn’s picture

yhahn commented

Great, will test out the patch and get back to you. Thanks!

JeremyFrench’s picture

JeremyFrench commented

Have just tested pach from #2, it works for me. Thanks

I'll leave as need review to give yhahn a chance to give feedback, but the patch looks good to me.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

Thanks! This is commited now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.