I note that both the base configuration and the drush command are creating files directly in /etc/apache2/sites-enabled. That directory should only have symlinks in it.

Config files for sites go into /etc/apache2/sites-available, and then the a2ensite is used to symlink them into sites-enabled. (or a2dissite to unlink them)

The attached (untested) patch takes care of that on the config part, but I wasn't quite sure how the drush command was behaving, so I didn't fix it there. I think as much as possible Quickstart should be a well-behaved Debian/Ubuntu system, and putting files right into sites-enabled is not well-behaved :-)

Thanks for all the work on this!

Again, this patch does not completely solve the problem, as the drush command still needs to be attended to.

CommentFileSizeAuthor
quickstart.use_sites_available.patch1.48 KBrfay

Comments

MichaelCole’s picture

MichaelCole commented
Status: Needs review » Postponed (maintainer needs more info)

Hi Rfay, thanks for the patch. I'll check it out.

Is there are reason to put them in the sites-available directory? It was an extra step I decided to skip, but it's easy to add in. In a way, it kind of complicates the UX for someone who isn't using the apache scripts. Did you run into something that broke?

I'm just wondering what the motivation is to do this.

Thanks for all the great feedback rfay,

Mike

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Basically, that's the way Debian works. You put a site description in /etc/apache2/sites-available and then use the a2ensite and a2dissite commands to manage it. (The same is true with modules and a2enmod/a2dismod). The idea is that you don't manage the symlinks, the system does.

The way it is right now, neither a2ensite nor a2dissite can be used, and anybody who comes in from a Debian/Ubuntu environment will be confused about why it's done differently (read "wrong" :-)

If it were important to do a one-off (like have a directory that contained site descriptions and did not work this way) then you could just create a directory and load all the files from it.

For example, you could put

Include /var/lib/quickstart/sites/

at the bottom of /etc/apache2/apache2.conf and it would work just fine (and not break any normal behavior)

Thanks for all the good work on this. It really is a delight.

MichaelCole’s picture

MichaelCole commented
Status: Postponed (maintainer needs more info) » Fixed

Thanks for the patch. I worked it into the install scripts and the drush scripts without too much incident. Will test it out tonight and roll a new version.

Thanks again for the feedback rfay,

Mike

MichaelCole’s picture

MichaelCole commented
Status: Fixed » Closed (fixed)