This is a follow up from #885228-74: CSS Files are in major need of clean up!.

Since #732914: Improve the markup/CSS for content and user filter forms has been committed, this we just need to remove the old stuff and do a little code style cleanup.

CommentFileSizeAuthor
#4 921386.2.patch11 KBjix_
#1 921386.patch11.41 KBjacine

Comments

jacine’s picture

jacine
she/her
Location New York
commented
Status: Active » Needs review
StatusFileSize
new 921386.patch11.41 KB

Attached patch removes the following blocks of stale code:

  1. Date & Time Settings. These are in a table in Drupal 7 now and the styles are not used anywhere else in core.
  2. table.package styles. These used to be used on module listing tables but are not anymore.
  3. thead th, which is a carbon copy of th, and totally useless.

It also does a number of code style cleanups. Nothing else. The rest has been taken care of either in the previous issue or other issues. YAY!

jix_’s picture

jix_ commented
Status: Needs review » Reviewed & tested by the community

Nothing weird in there :)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Needs work

Awesome patch!

+++ modules/system/system.base.css	24 Sep 2010 05:06:54 -0000
@@ -12,28 +12,28 @@
+  position: absolute;
   overflow: hidden;

o...p

Back RTBC afterwards!

Powered by Dreditor.

jix_’s picture

jix_ commented
Status: Needs work » Needs review
StatusFileSize
new 921386.2.patch11 KB
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.