is_null is mentioned in various files and modules. !isset is well known to be faster than is_null and should be usedd with variables. The patch is a no-brainer so I don't think there is a need to submit it for each comonent separately. Here is an atomic patch.

CommentFileSizeAuthor
base_atomic-isset_is_faster_than_is_null.patch6.83 KBmunzirtaha

Comments

munzirtaha’s picture

munzirtaha commented
Assigned: Unassigned » munzirtaha
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Closed (duplicate)

Duplicate of #921582: is_null should be replaced by !isset because it's faster

munzirtaha’s picture

munzirtaha commented

@sun: please don't close it as a duplicate. Though the title is the same, the patch is different. It's patching different set of files. I split the patches so it won't be huge and obseleted quickly by other patches before being committed. I also thought each componenet should have its own patch e.g this patch is fixing the base system not the modules.

munzirtaha’s picture

munzirtaha commented
Status: Closed (duplicate) » Needs review
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

From a review/commit POV, it's a lot easier if these are all in one issue. Rather than having to review/commit several different patches, we only work on one, and it goes in much faster/easier.

But at the very least, differentiating these by title would help a lot of people avoid mistakenly marking things as duplicates that aren't.

munzirtaha’s picture

munzirtaha commented
Status: Needs review » Closed (duplicate)

I now merged this patch with #921606: Various code uses is_null() instead of !isset() #2
Closing.