Using absolute path [#921702]

Comment	File	Size	Author
#4	custom_breadcrumbs-absolute_paths_support-921702-4.patch	1.83 KB	bpresles
	custom_breadcrumbs.module.patch	747 bytes	jean.cedric.t

Comment #1

jean.cedric.t commented 24 September 2010 at 15:18

After thinking about it, it maybe better to create another identifier.

Log in or register to post comments

Comment #2

MGN commented 6 October 2010 at 21:58

Status:

Needs review

» Needs work

Marking this as needs work because the suggested changes would break normal behavior. Custom breadcrumbs has always assumed the paths are internal drupal paths. I think the correct modification to use absolute paths would be to set $options['absolute'] = TRUE. Of course more would be needed to make this feature request work. I like the idea of adding a special identifier for this and would be happy to test a patch (against 6.x-2.x-dev) that did this.

Log in or register to post comments

Comment #3

MGN commented 13 December 2010 at 05:18

Status:

Needs work

» Closed (won't fix)

Closing this issue because it seems to have gone stale. See comments in #2 and reopen if there is interest in this.

Log in or register to post comments

Comment #4

bpresles commented 13 January 2011 at 13:52

Assigned:	jean.cedric.t	» bpresles
Status:	Closed (won't fix)	» Needs review

Status	File	Size
new	custom_breadcrumbs-absolute_paths_support-921702-4.patch	1.83 KB

Proposed better patch for this issue.

This in facts detects wether the path of the item is absolute or not (based on wether a host and scheme part is found by parse_url()), and generate an absolute link if it's the case. The original behavior remains strictly the same in case of relative paths.