Like the title says, currency is in US dollars despite my store being in British pounds and cart doesn't display when empty even with the setting unchecked. Neither of these happen with Ubercarts shopping cart. It's a great module I'd love to use, wondering if anyone had come across these before?

CommentFileSizeAuthor
#5 uc_microcart-922168-fix-currency-issue.patch941 byteswjaspers
#1 uc_microcart.module-922168-no-display-when-empty.patch994 byteswjaspers

Comments

wjaspers’s picture

wjaspers commented
StatusFileSize
new uc_microcart.module-922168-no-display-when-empty.patch994 bytes

The block not appearing when the setting is unchecked is a result of it not checking the setting on display.
Attached is a patch to fix it. I also clarified the the terminology, and ensured the setting explanation is translated.

wjaspers’s picture

wjaspers commented
Status: Active » Needs review

Arghh ... forgot to update the tracker again. I love the new Drupal site; but it's harder than ever to notice the tracker block.

gregoiresan’s picture

gregoiresan commented

Hi,

did you find out for your currency issue ? I didn't use the patch as I couldn't clearly see if it was inside... it seems that the hiding block issue is the only one fixed, isn't it ?

wjaspers’s picture

wjaspers commented

No, I didn't get around to the currency issue. I need to read up on the ubercart core to correctly load the currency.
I did, however, fix the block appearance problem.

wjaspers’s picture

wjaspers commented
StatusFileSize
new uc_microcart-922168-fix-currency-issue.patch941 bytes

Here's a fix for the currency issue. Fortunately, ubercart supplies a really simple hook for formatting the price uc_currency_format and automatically deals with finding your settings.

For the patch reviewer:
There are TWO patches to be reviewed on this thread.
The first fixes block displays and the second fixes the currency formatting problem.

gregoiresan’s picture

gregoiresan commented

What a quick answer, thanx !
I'll test it and tell you how it goes:)

summit’s picture

summit commented

Hi,
This patch #5 is working great! Thanks for posting.
Don't know why but on Ubercart 2.4 I had to add the uc_currency_format function: http://api.ubercart.org/api/function/uc_currency_format. It was //out on my install.
greetings, Martijn

summit’s picture

summit commented
Status: Needs review » Reviewed & tested by the community

Working great with patch #1 and #5! Greetings, Martijn

rich.yumul’s picture

rich.yumul commented
Status: Reviewed & tested by the community » Fixed

patches were committed to CVS, will be included in next release. :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.