Hello.

I've begun work to extend this module for purposes related to the Drupal Station module. I've cleaned up the code quite a bit, added a single shoutcast_get_xml() method, and now use this method to build both the block and the page. I've also added many of the other statistics available in SHOUTcast 1.9.8, including song history.

Although I anticipate doing a bit more work in relation to Station module integration, I'd love it if these updates made their way back into CVS here.

http://github.com/ckieffer/drupal-shoutcast

Comments

thumb’s picture

thumb commented

More updates:

Separate options for field display in the block and on the page. Consolidate table row building and use one table row building function for block and page. Updated docblocks.

Corrected admin display default options for page and block.

To do:

Caching doesn't seem to be working properly in this update. I also just realized that cache should be used if we're not able to get a response from the server.

Were you having any issues with caching?

yohnson’s picture

yohnson commented

I had not noticed any issues with the cache. the process is below

IF time to cache || cache empty.
---If either then get new data and populate the cache.

else
get data from cache and output

If the data is stale and the server is unresponsive what happens is the cache is cleared and nothing gets displayed, this will prevent the false feeling of a working installation while seeing stale cached data. I don't suggest showing stale data on error.

thumb’s picture

thumb commented

Thanks! I'll investigate further. I just pushed a complete rework of statistics display on the shoutcast stats page to my GIT repo. I'd love any feed back you can provide.

http://github.com/ckieffer/drupal-shoutcast

thumb’s picture

thumb commented

Cache fixed. I wasn't caching the object properly.

yohnson’s picture

yohnson commented
Status: Active » Needs review

Thank you very much for the code additions. I have integrated them into the new Development version for review and testing by the community. I will move it to a stable release in about 1 month to obtain some feedback, if any.

Thank you for your contribution thumb

thumb’s picture

thumb commented

Happy to help! I'll do my best to monitor bug reports to help out, if needed.

yohnson’s picture

yohnson commented
Version: 6.x-1.0 » 6.x-3.x-dev
yohnson’s picture

yohnson commented
Status: Needs review » Closed (fixed)