Hi jeff, a really minor patch:

After enabling the blocks: notice: Undefined index: url in /mnt/vbox-shared/70i/sites/all/modules/shurly/shurly.module on line 184.

CommentFileSizeAuthor
#2 e_notice_2a.patch2.77 KBcorbacho
#1 e_notice2.patch13.99 KBcorbacho
e_notice.patch896 bytescorbacho
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

corbacho’s picture

FileSize
13.99 KB

Here other two E_notices when clicking "Shrink it!" button:

# notice: Undefined offset: 2 in /mnt/vbox-shared/70i/sites/all/modules/shurly/shurly.module on line 533.
# notice: Undefined offset: 1 in /mnt/vbox-shared/70i/sites/all/modules/shurly/shurly.module on line 631.

First one due of that I don't have any settings saved for limiting rate by roles. I added 2 conditions to skip the flood checking fast when there are no settings.

Second one due of I'm testing in http://localhost and the host is only 1 word (not .com)

$base_domain_parts[count($long_domain_parts) - 1]

So if try to shrink http://madonna.com, it will count (2 - 1 = 1), when $base_domain only has [0] = localhost. index [1] is not defined.

You can say, I don't care if it rises a E_notice in localhost. But same problem would happen if try to shrink a 3 parts domain queen.co.uk when base url it's a 2 parts domain

I included the previous patch in this one (3 changes adding conditions).

Aside of these minors, I'm quite impressed of the module, it's exactly what I needed (that ready-to-go-bookmarklet is priceless) and works smoothly. Thanks

corbacho’s picture

FileSize
2.77 KB

Cleaner patch (aptana has a "remove whitespace automatically" option that messed up the file)

lnunesbr’s picture

Status: Active » Closed (cannot reproduce)

Cannot reproduce, seems to be working as expected.