Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi jeff, a really minor patch:
After enabling the blocks: notice: Undefined index: url in /mnt/vbox-shared/70i/sites/all/modules/shurly/shurly.module on line 184.
Comment | File | Size | Author |
---|---|---|---|
#2 | e_notice_2a.patch | 2.77 KB | corbacho |
#1 | e_notice2.patch | 13.99 KB | corbacho |
e_notice.patch | 896 bytes | corbacho | |
Comments
Comment #1
corbacho CreditAttribution: corbacho commentedHere other two E_notices when clicking "Shrink it!" button:
# notice: Undefined offset: 2 in /mnt/vbox-shared/70i/sites/all/modules/shurly/shurly.module on line 533.
# notice: Undefined offset: 1 in /mnt/vbox-shared/70i/sites/all/modules/shurly/shurly.module on line 631.
First one due of that I don't have any settings saved for limiting rate by roles. I added 2 conditions to skip the flood checking fast when there are no settings.
Second one due of I'm testing in http://localhost and the host is only 1 word (not .com)
$base_domain_parts[count($long_domain_parts) - 1]
So if try to shrink http://madonna.com, it will count (2 - 1 = 1), when $base_domain only has [0] = localhost. index [1] is not defined.
You can say, I don't care if it rises a E_notice in localhost. But same problem would happen if try to shrink a 3 parts domain queen.co.uk when base url it's a 2 parts domain
I included the previous patch in this one (3 changes adding conditions).
Aside of these minors, I'm quite impressed of the module, it's exactly what I needed (that ready-to-go-bookmarklet is priceless) and works smoothly. Thanks
Comment #2
corbacho CreditAttribution: corbacho commentedCleaner patch (aptana has a "remove whitespace automatically" option that messed up the file)
Comment #3
lnunesbrCannot reproduce, seems to be working as expected.