Stop "The changes have been saved." message from showing when email address is changed [#922554]

Hello,

When a user changes his/her email address the following message is shown:

-A confirmation email has been sent to your new email address. You must follow the link provided in that email within 24 hours in order to confirm the change to your account email address.
-The changes have been saved.

The first message gives the user instructions on how to confirm the email address change. [good] I find the second message "The changes have been saved" to be strange/confusing as technically the changes have not been saved yet. [not good] Also, when save is clicked the email address changes back to the original email address (not the new email address) until the confirmation link is clicked. [more confusion] So the first of the two messages above makes sense, but the second message does not/confusing.

It would be nice if "The changes have been saved" is not shown as an informational message when the email address is changed.

I hope this feature request to stop the message "The changes have been saved" from showing may be considered.

Great module!

Comment	File	Size	Author
#7	email_confirm.module.922554.patch	1.76 KB	jaydub

Comments

Comment #1

Bilmar commented 25 September 2010 at 15:42

Title:

don't show "The changes have been saved." when email address is changed

» Stop "The changes have been saved." message from showing when email address is changed

Comment #2

jaydub commented 9 October 2010 at 02:31

Priority:

Normal

» Minor

The string "The changes have been saved" come from Drupal core via the User module. When a user edits their email address or any field in their profile in Drupal and hits save/submit you will see that string.

In the case of the email address being changed AND email confirm module in place then to some degree you are right in that the email address is not changed - until confirmed.

I can see if I can remove the message from core from the message queue that drupal_set_message is building but this is a low priority issue given that this module is not the source of that message string.

Comment #3

jaydub commented 24 October 2010 at 19:51

Assigned:

Unassigned

» jaydub

Comment #4

Bilmar commented 25 October 2010 at 04:54

Hi jaydub,

Thanks for considering this! I understand the source of the message is from core and so should be considered a low priority here. I believe it will improve the 'what does that mean' situation that many users have been inquiring about on a site I built and solidify the concept of making users confirm their email address change. I think this module is GREAT and keeps users on sites with a valid email address at all times.

Thanks again and I look forward to helping with any testing in the future.

Active

» Needs review

Status	File	Size
new	email_confirm.module.922554.patch	1.76 KB

Please try this patch against the current code in CVS. In my limited testing it gets rid of the message set by the User module without touching the User module code.