Solution: Add class="modalframe-exclude", see patch.

CommentFileSizeAuthor
#3 hosting-922716-expand_link_opens_new_window_fix.patch1002 byteshelmo
#1 hosting-922716-expand_link_opens_new_window_fix.patch871 byteshelmo

Comments

helmo’s picture

helmo commented
StatusFileSize
new hosting-922716-expand_link_opens_new_window_fix.patch871 bytes
Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs work

The patch contents look cut off, or is it just me?

Also the bug (used to but) doesn't occur for me in Google Chrome - I thought your previous patch fixed it. Is this actually still an issue? If so, in which browsers?

helmo’s picture

helmo commented
Status: Needs work » Needs review
StatusFileSize
new hosting-922716-expand_link_opens_new_window_fix.patch1002 bytes

Indeed, a copy paste must have cut off the end of these lines :(

I just confirmed that a new window is still being opened when tested with FireFox 3.6.10 and Opera 10.62 on Ubuntu.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Fixed

Tested in Firefox and reproduced, patch fixes it, committed :)

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 756ced0 on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by mig5: 
    #922716 by helmo - fix expand link from opening new tab in some browsers

  • Commit 756ced0 on 6.x-2.x, 7.x-3.x, dev-ssl-ip-allocation-refactor, dev-sni, dev-helmo-3.x by mig5: 
    #922716 by helmo - fix expand link from opening new tab in some browsers