Garland does not display secondary tabs when color module is off

No code to review.

The issue title is a little missleading, because we are talking about local task tabs and not about a profile specific issue.
However is there any progress on this topic? I'm coming from http://drupal.org/node/93044 (thanks Heine) and I really hope we can solve this one. Neither Garland nor any other (core) theme should depend on the color.module IMO. Local task tabs are a critical theme (intrinsic) feature. Why is color.module needed for Garland theme? What parts are not available without it? CSS? Is there anybody working on this?

Very little this has to do with color module. If color is off then the _phptemplate_variables, after settings $vars['tab2'] returns an empty array. Opsie.

Also there shoudl be some decision made whether _color_page_alter uses references or returns the changed variables. Both are unnecessary and if this is the function name, I am inclined towards references.

The culprit is garlands template.php, which returns an empty array when color module is not enabled.

/**
 * Override or insert PHPTemplate variables into the templates.
 */
function _phptemplate_variables($hook, $vars) {
  if ($hook == 'page') {

    if ($secondary = menu_secondary_local_tasks()) {
      $output = '<span class="clear"></span>';
      $output .= "<ul class=\"tabs secondary\">\n". $secondary ."</ul>\n";
      $vars['tabs2'] = $output;
    }

    // Hook into color.module
    if (module_exists('color')) {
      return _color_page_alter($vars);
    }
  }
  return array();
}

No time to roll a proper patch unfortunately.

Sorry, I should have refreshed; didn't see your reply chx.

The patch works nicely. Thx chx.

Committed to CVS HEAD. Thanks!