Panels IPE has not been saving properly when internationalized because the javascript attached to the save function has been only firing for buttons named literally "Save" and "Cancel". This small patch adds an id to the cancel button to distinguish it and then looks for both buttons by id rather than value, allowing the text to be translated.

If there is something wrong with this approach, we could pass the internationalized versions of those strings to javascript, and use those, but this seems more logical.

(first multifile patch with CVS, happy to reroll if something not right about patch structure.)

CommentFileSizeAuthor
panels_ipe_i18n.patch1.72 KByareckon

Comments

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Looks okay. Committed. D7 shouldn't experience this problem as I had to rewrite how the buttons are detected there.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

patrickroma’s picture

patrickroma commented

works perfectly.