#162047: .container-inline class overridden by system.theme.css; also not working with .form-actions had to change System module's CSS selectors for LABELs.

CommentFileSizeAuthor
#4 drupal.simpletest-label.4.patch5.05 KBsun
#2 simpletest-before.png37.09 KBmikey_p
#2 simpletest-after.png43.08 KBmikey_p
drupal.simpletest-label.0.patch3.6 KBsun

Comments

jacine’s picture

jacine
she/her
Location New York
commented

.

mikey_p’s picture

mikey_p commented
StatusFileSize
new simpletest-after.png43.08 KB
new simpletest-before.png37.09 KB

I'm not that familiar with the CSS, but this looks good to me, just not sure about the hunk in Bartik. Here's before and after screenshots.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

The remaining thing I find odd is the manually inserted DIV.indentation for the individual test case rows.

1) Not sure why manual markup is used for that in the first place. (And, markup that is actually intended for TableDrag styling...)

2) Not sure whether test case titles actually need to be indented...? If really needed, then I think that should be done by adding padding-left via CSS.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new drupal.simpletest-label.4.patch5.05 KB

Replaced that DIV.indentation with proper CSS.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Assigned: Unassigned » sun

This form really looks totally broken currently and hinders development workflow. Feedback, anyone?

mikey_p’s picture

mikey_p commented
Status: Needs review » Reviewed & tested by the community

This looks cleaner to me, I'm not up on CSS standards in core, but I don't see anything that stands out.

Before:
Only local images are allowed.

After:
Only local images are allowed.

edit: input format

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.