Given that $currencies is defined as

Array ( [values] => Array ( [USD] => US Dollar [CAD] => Canadian Dollar [EUR] => Euro [GBP] => British Pound [JPY] => Japanese Yen [CHF] => Swiss Franc ) [default] => EUR )

, shouldn't the lines 478 and 692 in storminvoice.theme.inc be

$mycurrency = $currencies['values'][$myorg->currency];

instead of

$mycurrency = $currencies[$myorg->currency];

?

CommentFileSizeAuthor
#3 924436.patch814 bytestchurch

Comments

tchurch’s picture

tchurch commented
Assigned: Unassigned » tchurch

I haven't tested your suggestion but I do notice this on line 475:

$currencies = stormattribute_attributes_bydomain('Currency');
$currencies = $currencies['values'];

however this is missing from line 690:

$currencies = $currencies['values'];

This could be why the currency is not set correctly on the HTML print-out.

(also with the countries variable too at line 690):

$countries = $countries['values'];

I've tested this change and it now displays the correct information on the HTML print-out.

I will create a patch for them (once other patches are confirmed and committed).

agsh’s picture

agsh commented

That solves the problem. Thanks a lot.

tchurch’s picture

tchurch commented
Status: Active » Needs review
StatusFileSize
new 924436.patch814 bytes

Patch to test.

juliangb’s picture

juliangb commented
Status: Needs review » Reviewed & tested by the community
tchurch’s picture

tchurch commented
Version: 6.x-1.34 » 6.x-1.x-dev
Status: Reviewed & tested by the community » Needs review
tchurch’s picture

tchurch commented

#3: 924436.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 924436.patch, failed testing.

tchurch’s picture

tchurch commented
Status: Needs work » Fixed

The patch failed on -dev because I had already committed it but it's only 2 lines and no other changes were done to this file yet.
Therefore I set to fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.