So here's a start to the d7 port.

I of course got rid of the elements that where ported from d7 for d6.

I tested this by writing a module that implement all the fields. They all work nicely.

CommentFileSizeAuthor
#7 924766_2.patch24.2 KBericduran
#6 924766_2.patch17.63 KBericduran
#4 924766.patch23.25 KBericduran
#1 element-d7-port.patch17.65 KBericduran

Comments

ericduran’s picture

ericduran commented
StatusFileSize
new element-d7-port.patch17.65 KB

Oops, I forgot the patch.

alanburke’s picture

alanburke commented

Subscribe

ericduran’s picture

ericduran commented
Status: Needs review » Needs work

I notice a couple of problems. Patch is uncomplete.

ericduran’s picture

ericduran commented
Status: Needs work » Needs review
StatusFileSize
new 924766.patch23.25 KB

Hey,

I decided to clean this up. Now all the elements are working as they're supposed to.

Ready to be review. :-)

ericduran’s picture

ericduran commented
Assigned: Unassigned » ericduran

assigning to myself for better tracking. :)

ericduran’s picture

ericduran commented
StatusFileSize
new 924766_2.patch17.63 KB

Ok, here's a better patch.

Some reviews would be great :-)

ericduran’s picture

ericduran commented
StatusFileSize
new 924766_2.patch24.2 KB

Ooops, forgot the -N switch.

Here's an update

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I took some liberties with the patch, simplifying some code using core's element_set_attributes() as well as adding our own helper function elements_add_autocomplete(). I also backported all these improvments to Drupal 6 and on both branches they were working for me.

http://drupal.org/cvs?commit=463114

Thanks eric for all your work on this issue!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

FYI a new 'DRUPAL-7--1' branch was created from HEAD and a development release was created. Tomorrow I'll likely release a matching 6.x and 7.x versions, so any testing you can get in between now and then would be awesome.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.