Hi,

I am having some interesting problems with input formats of nodes started by email. They look fairly decent at first, but with hard returns at the end of each line - probably at about 70 chars like an email. HTML is stripped out - seems that it's being converted to plain text like the old content notifications used to be converted. Some content, as discussed in another issue, is truncated.

What I'd like to do:

* HTML messages are posted as HTML, like through the web interface
* plain text messages have hard returns at the end of each line removed for smoother paragraphs
* track down the truncation bug (separate but maybe related issue)

Cheers,

Tobias

Comments

tobias’s picture

tobias commented

Another issue I forgot to mention that makes me think this is an input formats problem is that when I edit a post created by email, all paragraph breaks disappear in the editor and everything runs together. None of the two input formats I have turned on (filtered html for users and full html for admins) fixes this.

Cheers,

Tobias

kyle_mathews’s picture

kyle_mathews commented
Status: Active » Fixed

The input format used to format the messages is whatever your default input format is.

Only the plain text version of emails are being saved as pulling out the HTML successfully and in a consistent manner is rather difficult to do correctly across the different email clients + doing that would break the existing method for hiding the quoted portion of emails.

I've tried removing the hard returns on emails and IMO that makes the typical email look far worse. Plus it can ruin sometimes specific formatting people put in their emails.

If you'd like to create a separate issue for pulling HTML rather than text from emails you may but I'm closing this one as its original topic was a support request on input filters.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

donquixote’s picture

donquixote commented
Status: Closed (fixed) » Active

@kyle_mathews (#2):

The input format used to format the messages is whatever your default input format is.

Would it not be better to make that configurable?

mrfelton’s picture

mrfelton commented

It really would be better to make it configurable, since the input filter that is included with this module does not function correctly with the HTML corrector filter also enabled.

It's not really acceptable to have a default input filter without an HTML corrector, yet og_mailinglist currently forces you to do so.

donquixote’s picture

donquixote commented

Just to mention it - what about htmlpurifier instead of the built-in html corrector?

kyle_mathews’s picture

kyle_mathews commented

The problem is almost certainly that the HTML the input filter generators isn't correct. I just haven't had time to look at how exactly the html corrector is breaking things. If you wanted to look into that, it shouldn't be too hard to fix.

kyle_mathews’s picture

kyle_mathews commented
Status: Active » Fixed

After poking away at this for awhile, I figured out how to make (hopefully) everyone happy.

http://drupalcode.org/project/og_mailinglist.git/commitdiff/7c1e0e7?hp=9...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.