Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.This is a correction/improvement on my earlier patch in http://drupal.org/node/774422 that has been committed.
With this patch width and height is set correctly and Colorbox is told to use the iframe mode.
The colorbox-load functionality needs to be activated in the Colorbox settings. Maybe this should be added to the README and/or add this setting somewhere on the Embedded Media Field settings pages.
A tips to the module maintainer is to make it possible to set $attributes and $destination in the "theme_emvideo_*box" functions so theme_emvideo_modal_generic can be made cleaner.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | emfield_colorbox_924908_5.patch | 866 bytes | frjo |
| #3 | emfield_colorbox_924908_3.patch | 1.25 KB | frjo |
| emfield_colorbox_correction.patch | 1.25 KB | frjo |
Comments
Comment #1
alex ua commentedThanks- I've committed this patch.
Comment #2
jcmarco commentedPHP Parse error: parse error in xxxxxxxxxxxxx\sites\all\modules\emfield\contrib\emvideo\emvideo.theme.inc on line 245
In line 245: the + was lost in the commit.
Comment #3
frjo commentedImproved patch that works well with Vimeo as well.
Comment #4
alex ua commentedSorry about that, not really sure how I did that... Anyway, I corrected it...
Comment #5
frjo commentedMinor fix for Vimeo videos, height and width adjustments only.
This was also in patch #3 but I posted that one to late, and in the wrong language :-).
Sorry for the hassle.
Comment #6
aaron commentedgot it, thanks @frjo!