Currently, all taxonomy terms are always listed in the "Add term" dropdown. However, not all vocabularies are typically used for access control, and some vocabularies (particularly freetag vocabularies) can have hundreds or thousands of terms. This can make it difficult and time-consuming to find the desired terms in the add term box.

Ideally, the form might be enhanced with a sort of hierarchical select, but the easiest improvement would be to allow the administrator to configure which vocabularies are shown for access control. All vocabularies would be enabled by default, but the administrator could disable them on a settings page.

CommentFileSizeAuthor
#2 tac_925166.patch3.09 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented

This would also resolve #114341: Exclude freetagging enabled vocabularies from category permissions page, so marking that one as a duplicate.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new tac_925166.patch3.09 KB

Attached patch implements this feature. Use the -p option to apply this patch.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Needs work

The link location on the settings page uses the wrong t() substitution, so the url path becomes: admin/user/taxonomy_access/@%3Cem%3E/admin/user/taxonomy_access%3C/em%3E

Also, we probably don't need to include the main configuration in the menu twice.

xjm’s picture

xjm
she/her
Primary language English
commented

Also, what happens if a user configures terms in a vocabulary, then disables that vocabulary? The rules would probably remain in effect until the next time the TAC form was submitted for a given role, creating an unexpected change in access control. At the least, we need a warning on the settings form that disabling vocabularies that have configurations may have unexpected results; ideally, we would do some sort of validation to disallow disabling of vocabularies with rules.

xjm’s picture

xjm
she/her
Primary language English
commented

Also, we should possibly add a reminder on the TAC form itself that unchecked vocabularies will not be listed.

xjm’s picture

xjm
she/her
Primary language English
commented

Additionally, deletion of this variable should be added in hook_uninstall().

alb’s picture

alb commented

I applied the patch but the page admin/user/taxonomy_access/configure
and admin/user/taxonomy_access/settings are not found

for which version of tac work?

xjm’s picture

xjm
she/her
Primary language English
commented

#7: Try clearing your menu cache. There is a bug such that admin/user/taxonomy_access/configure is not found, but admin/user/taxonomy_access/settings should work fine. In any case, the patch is marked "needs work" for a reason. ;)

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +TAC UX

Tagging.