page.tpl.php: site logo and site name should not be clickable on front page [#925216]

Comment	File	Size	Author
#3	zen-925216.3.patch	3.51 KB	jix_
#2	zen-925216.2.patch	3.51 KB	jix_
#1	zen-925216.1.patch	3.47 KB	jix_

Comment #1

jix_ commented 29 September 2010 at 10:18

Status:

Active

» Needs review

Status	File	Size
new	zen-925216.1.patch	3.47 KB

It is! Here's a patch that only links the site logo and name when we're not on the frontpage.

I had to move some of the code to template.php. if $site_name, if $title, if $is_front altogether cannot be done efficiently in page.tpl.php. You'd have to write the whole HTML block for the site name three times, or write ifs around the <a href=""> and </a>; yikes.

Also, as the <a> around the logo is now conditional, you can't really rely on the ID being on the <a>, so I wrapped it in a <div id="logo">.

One thing that does get lost in the patch currently is the <span> inside the site name's <a>. I personally don't think it needs to be there in the first place, but I'd like some feedback on it. Should we keep the span? If so, where should we add it?

Log in or register to post comments

Comment #2

jix_ commented 30 September 2010 at 10:04

Status	File	Size
new	zen-925216.2.patch	3.51 KB

Friggin' tabs.

Log in or register to post comments

Comment #3

jix_ commented 30 September 2010 at 10:15

Status	File	Size
new	zen-925216.3.patch	3.51 KB

Sorry, my editor is giving me shit. All tab characters should be gone now.

Log in or register to post comments

Comment #4

pfrenssen

Sofia

commented 23 October 2011 at 20:02

Component:

PHP Code

» layout.css

It is a convention that the logo and the first link in the main navigation link to the front page. These should not be removed or altered under any circumstances. If they are not clickable they are broken in the user's view.