Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.When the title is active (for instance when the user clicks on the title text) it jumps out of position.
This rule cases the problem and I can't see any use for setting padding to zero here.
#overlay-title:active,
#overlay-close:hover,
#overlay-close:focus {
padding: 0;
}
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | overlay-925398.patch | 564 bytes | ptrl |
| overlay-title-active.png | 6.21 KB | ptrl | |
| overlay-title.png | 5.5 KB | ptrl |
Comments
Comment #1
ptrl commentedHere is the patch.
Comment #2
betz commentedTested patch, did the trick, but i'm also wondering why this css rule exists in the first place.
Comment #3
webchickWow, never noticed that before. What a stupid bug! :)
Patch does indeed fix the problem but this close to RC I'd like to see some more testing of this in multiple browsers just in case it breaks something. To be on the safe side, I'll probably wait until next week to commit this.
Comment #4
webchickMarking needs review, if you can ping back with what browsers you've tested this in and make sure IE 7&8 and Safari or Chrome are in that list, this is probably good to go.
Comment #5
ptrl commentedSorry missed your posts. This have been tested in IE7, IE8 Firefox 3.6, Safari 5 and Chrome 8 without any problems.
Been looking around if this code really does anything, but it looks like it was only placed there to annoy users :)
Comment #6
Tor Arne Thune commentedTested this in Chromium 10.0.617.0 and Firefox 3.6.13 on Linux.
Before patch : Text jumps out of position when clicked.
After patch: Text stays in same position when clicked.
Conclusion: Fixed ;)
Comment #7
webchickWow, this totally fell off my radar! Sorry about that. :( Thanks a lot for the testing!
Committed to HEAD.