bydga [bydga]

Hello, and thank you for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site; for modules, it should include also a comparison with the existing solutions.

I think the motivation message is actually satisfactory. This is a *very* simple module, and his existing message covers the functionality.

Some notes:

1. Please remove the version line from the .info file.
2. Add CVS ID tags as described at http://drupal.org/node/100748
3. Please add @file docblocks to the .install and .module files: http://drupal.org/node/1354#files
4. Please document your functions according to the doxygen standards: http://drupal.org/node/1354
5. Please add a README.txt as per http://drupal.org/node/188986

The actual code looks good and matches the coding style. Just please add some documentation to it.

Hi bydga.

This is looking much better. However, I have two minor follow up points on the function documentation:

1. taxonomy_force_leaf_uninstall() needs a function docblock.
2. According to the doxygen standards mentioned above, the proper format for a hook implementation function docblock should be something similar to:
   

   /**
    * Implements hook_help().
    */
   

   while your current versions are:

   /**
    * Implementation of hook_nodeapi.
    */
   

   . It's a minor point, but it is very useful to have consistent documentation standards for when your function documentation is displayed on sites such as http://drupalcontrib.org/.

Once these are corrected, we should be able to approve CVS access.

Note: I cannot approve or decline CVS account applications, but I'm trying to help real coders in reviewing applications more efficiently. The following comments are *not* ground for approving or declining an application – just a help to get going.

I have three comments for this application:
* I'd like to know if there are any existing modules doing the same thing. (A quick search I made yielded no result, but pointing this out in this application seems relevant.)
* The module should depend on the Taxonomy module in core.
* Code and concept of this module look nice and clean.

Since the Taxonomy dependency is not a minor issue, I'm changing this application status to 'needs work'.

Good luck!

Please read all the following and the links provided as this is very important information about your CVS Application.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:Migrating from CVS Applications to (Git) Full Project Applications.

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• If your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.