Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.To update the code to Drupal 5.0 Beta 1, you must change the module_exist call on line 132 to module_exists, with an 's'.
// Change the following:
if(!module_exist('profile')) {
// To:
if(!module_exists('profile')) {| Comment | File | Size | Author |
|---|---|---|---|
| #5 | googleanalytics_0.patch | 3.96 KB | harry slaughter |
| #4 | googleanalytics.patch | 3.79 KB | harry slaughter |
Comments
Comment #1
stevenpatzThere is no patch.
Comment #2
robloachAfter making the change from module_exist to module_exists, the user role tracking feature still doesn't work. You set it to track the anonymous role, press save, but it doesn't save the user role settings....
Comment #3
harry slaughterthey've gotten rid of hook_settings() so the old way of saving admin settings won't work.
i'll have a patch shortly, you guys can help me test it :)
Comment #4
harry slaughterbe sure to update to latest cvs before applying this patch
Comment #5
harry slaughteroops! missed something.
use this patch instead
Comment #6
Tobias Maier commentedminor thing:
remove
?>per drupal coding standards: http://drupal.org/node/545
Comment #7
moshe weitzman commentedjavascript can now have own settings storage within drupal framework. at some point, we should do an even more thorough port of this module. see http://drupal.org/node/64279#drupal_call_js
Comment #8
buddaApplied changes and also updated the .install to generate the correct variable names for tracking upon module installation.
Committed to CVS HEAD.
Comment #9
budda@moshe
What do you want me to do with that JS function? From it's description I'm not clear what use it is in the context of the current G Analytics code.
Comment #10
moshe weitzman commentedi'm not sure either. when i first looked at drupal_add_js, i thought we could use it but we use hopok_footer so the inline feature won't help.
thanks for the patch and the quick apply.
Comment #11
(not verified) commented