When embed code from Sound Cloud is pasted in to the field, it does not display anything, it only displays when you paste in the URL directly.

CommentFileSizeAuthor
#4 926244.media_soundcloud.embed-code.patch853 bytesjoachim
#3 embed.patch885 bytesmccarthyr
#1 embedCode.patch751 bytesmccarthyr

Comments

mccarthyr’s picture

mccarthyr commented
Title: Embed code not working » Embed code not working - fixed
Status: Active » Fixed
StatusFileSize
new embedCode.patch751 bytes

Attached is a patch that allows for embed code to be pasted into the field.

joachim’s picture

joachim commented
Title: Embed code not working - fixed » Embed code not working
Status: Fixed » Needs work 
    // If this is NULL, then the Embed code instead of URL has been passed in and just return the code.
  if (!$item['data']['swf']) {

Comments and code don't agree! What happens if the array key is zero or an empty string? Should we be testing for NULL or just a false value?

For future reference, please create patches from the base folder of a module -- see http://drupal.org/patch/create for more details.

Also, 'fixed' is only set when the patch is committed. It should have been 'needs review'; it's now 'needs work' ;)

mccarthyr’s picture

mccarthyr commented
StatusFileSize
new embed.patch885 bytes

Updated patch attached.

joachim’s picture

joachim commented
Status: Needs work » Fixed
StatusFileSize
new 926244.media_soundcloud.embed-code.patch853 bytes

Patch still doesn't apply -- rolled against the wrong folder again. Also try to avoid whitespace changes getting into patches; in longer patches they make reviewing a real pain and at any rate always need to be picked out by hand.

Committed the attached fixed version of the patch to CVS.

#926244 by mccarthyr: Fixed support for embed codes.

New release on the way.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.