Since #855602: Allowing modules to contains skins has landed and as suggested, Skinr should include an example skin to ship with so that people can test and see how to include skins with their own modules.

Comments

ericduran’s picture

ericduran commented

Do we want a skinr_example module ? or do we just want to ship with a skin in the skinr module?

I like the "skinr_example" module option that way we can also show how to implement a module that has a skinr handler and not just a module that contains a skin. Just an idea.

jacine’s picture

jacine
she/her
Location New York
commented

I'd definitely rather go the skinr_example.module route.

ChrisBryant’s picture

ChrisBryant commented

Yes, definitely skinr_example.module. :-)

jhebel’s picture

jhebel commented

Ok, I'm starting work on skinr_example.module

I'll report back soon!

jacine’s picture

jacine
she/her
Location New York
commented

Any updates on this?

ChrisBryant’s picture

ChrisBryant commented
Title: Include an example skin with the Skinr module » Include a skinr_example.module with the Skinr module that includes an example skin
Status: Active » Closed (fixed)

Updating the title and closing this issue since it's now been baked in with Eric's lovely patch at:

#897822: [META ISSUE] Stop storing skins in .info files; implement skins as PHP instead

If anyone else has improvements or additions to the skinr_example module, please create a new issue for those.

jacine’s picture

jacine
she/her
Location New York
commented

Err, that's not even close to finalized. That patch is still in a very unstable and early state. We don't even know that this format is what we will end up having. This should not be used by anyone right now.

ChrisBryant’s picture

ChrisBryant commented
Status: Closed (fixed) » Active

Ok, switching back to active then. Maybe Eric's patch should be split up so the skinr_example.module can be worked on here separately.

moonray’s picture

moonray commented
Version: 6.x-2.x-dev » 7.x-2.x-dev

Let's do this in D7 first in any case.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Fixed

I think that the testing module + themes and their example skin implementations are sufficient. The documentation may point to them, if necessary. We are going to heavily advance on them over time, as we need to test all available features and expectations anyway.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.