The Druplicon in the Garland default theme is broken on all pages other than root (/).

Investigating, looks like logo output is something like:

<img src="files/color/garland-7354b0d8/logo.png" [...]

...which means its relative to current directory.

Seems page.tpl.php needed base_path specified on line 39 as in:

            if ($logo) {
              print '<img src="'. check_url($base_path) .  check_url($logo) .'" alt="'. $site_title .'" id="logo" />';
            }

Wohoo! Finally working (via PuTTY) on my dedicated Linux box. The command line is so powerful.

Attached is a patch. Works for me.

CommentFileSizeAuthor
#4 color.module.logo.patch.txt618 bytesRok Žlender
page.tpl.php_1.patch583 bytesDaveNotik

Comments

heine’s picture

heine commented
Status: Needs review » Closed (duplicate)

http://drupal.org/node/92003

DaveNotik’s picture

DaveNotik commented
Status: Closed (duplicate) » Needs review

That issue opened first, but this one contains more information and a patch. Figured it's best to approve/disapprove this patch.

Tobias Maier’s picture

Tobias Maier commented

i dont think that we need check_url() around $base_path, because we dont do that in the other themes:
bluemarine: http://api.drupal.org/api/HEAD/file/themes/bluemarine/page.tpl.php/source
pushbutton: http://api.drupal.org/api/HEAD/file/themes/pushbutton/page.tpl.php/source
garland: http://api.drupal.org/api/HEAD/file/themes/garland/page.tpl.php/source

I know that check_url($base_path) is already used in this theme, but it could be removed imho
and if you dont like that you could use base_path()

Rok Žlender’s picture

Rok Žlender commented
StatusFileSize
new color.module.logo.patch.txt618 bytes

IMO this is a color.module problem. Because $logo variable should hold complete path to logo. If you look at bluemarine page.tpl.php it justs prints logo
<img src="<?php print $logo ?>

In color.module there is a function _color_page_alter where $logo is overriden but without base_path(). I think my patch should fix this.

Tobias Maier’s picture

Tobias Maier commented
Status: Needs review » Reviewed & tested by the community

you are right

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)