The small plus buttons that expand a menu in the admin toolbar don't work when overlay is present on a page.

That's the only problem I've noticed with admin's support for overlay.

CommentFileSizeAuthor
#7 admin.patch438 bytesjurgenhaas
#1 admin-927944-overlay.diff772 bytesskwashd

Comments

skwashd’s picture

skwashd commented
Status: Active » Needs review
StatusFileSize
new admin-927944-overlay.diff772 bytes

The attached patch fixes the problem. The new <a> needs the overlay-exclude class to stop the overlay module hijacking the click event on it.

yhahn’s picture

yhahn commented
Status: Needs review » Fixed

Thanks. http://drupal.org/cvs?commit=465668

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

drclaw’s picture

drclaw commented
Status: Closed (fixed) » Active

I'm still unable to expand the menu items once the overlay has been accessed... Am I the only one...?

caschbre’s picture

caschbre commented

Are you using the jquery_update module by chance? I'm running into a similar issue that is a combination of overlay, jquery_update, and admin.

#1064198: jQuery 1.5 and Devel Module

drclaw’s picture

drclaw commented

Nope, no jQuery update. Just admin and overlay.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Version: 7.x-2.0-beta2 » 7.x-2.0-beta3
StatusFileSize
new admin.patch438 bytes

Here you go, I finally found the real issue and the patch that resolves it is attached.

The problem is that there is a menu.data('disableMenu', true); being used when clicking on a link, which is required to prevent the menu.drilldown('setActive') being called, because otherwise the link wouldn't be opened. Normally, this is no problem, because a new page gets loaded and the assigned data gets lost anyway.

However, if overlay is active, the page doesn't get reloaded and the data disableMenu=true remains assigned to the menu which prevents further execution of menu.drilldown

Well, I believe that disabling the menu is only required once, so the solution in the patch just unsets that setting immediately and I now have it working nicely and as expected.

paulgemini’s picture

paulgemini commented

Didn't fix it for me.

nithinkolekar’s picture

nithinkolekar commented
Issue summary: View changes

#7 patch worked with 7.x-2.0-beta3+8-dev , Jquery > 1.7 and Drupal core 7.34.

sickness29’s picture

sickness29 commented
Status: Active » Closed (outdated)

D7 reached its EOL back in January 2025, and there is no active release for D7 for this module anymore.
Development or support is not planned for D7. All D7-related issues are marked as outdated in a bunch.

Everyone can apply the patch above (not tested by the maintainers, tested by the community) to their D7 projects.
If the issue remains relevant for D10+ versions, merge requests with proposed solutions for a new module version (D10+) are welcome in a new follow-up issue.

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.