variables not checked before assigning = bad

CommentFileSizeAuthor
formfilter_ui_undefined_indices.patch2.2 KBeMPee584

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Needs work

Thanks, looks good except for this portion:

+++ formfilter_ui/formfilter_ui.module
@@ -99,9 +99,9 @@ function formfilter_ui_form_alter(&$form, &$form_state, $form_id) {
-      $form['#suffix'] .= '<div>'. l(t('Filter this form'), $_GET['q'], array('query' => 'formfilter_id='. $form_id)) .'</div>';
+      $form['#suffix'] = '<div>'. l(t('Filter this form'), $_GET['q'], array('query' => 'formfilter_id='. $form_id)) .'</div>';

Will overwrite any existing #suffix.

eMPee584’s picture

eMPee584 commented

o0ps u're right..

  $form['#suffix'] = (isset($form['#suffix']) ? $form['#suffix'] : '') .'<div>'. l(t('Filter this form'), $_GET['q'], array('query' => 'formfilter_id='. $form_id)) .'</div>';
pillarsdotnet’s picture

pillarsdotnet commented

Also see patch in #731174: Correct node_form() usage in formfilter_ui_node_form() function at formfilter_ui.module line 49, and other PHP warnings which includes a fix to this problem and others.

pianomansam’s picture

pianomansam commented
Status: Needs work » Closed (duplicate)

Duplicate of #731174: Correct node_form() usage in formfilter_ui_node_form() function at formfilter_ui.module line 49, and other PHP warnings